Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relegate share notifications to -debug='stratum' #87

Open
maaku opened this issue Aug 23, 2020 · 1 comment
Open

Relegate share notifications to -debug='stratum' #87

maaku opened this issue Aug 23, 2020 · 1 comment

Comments

@maaku
Copy link
Contributor

maaku commented Aug 23, 2020

Right now any mining node's debug output is chock full of share notifications, if the miner requests a low difficulty. This ends up filling the log buffer and at some point the old history gets truncated. Share notifications are only really useful when debugging miner connections, so it should only be output when -debug='stratum is set.

@maaku
Copy link
Contributor Author

maaku commented Jan 16, 2021

As I think about this some more, share notifications might be useful to have in general, so long as they are limited in frequency. Maybe if a partial work gets above a critical threshold it is logged to the main log, instead of just the stratum log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant