Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 963 #1377

Closed
wants to merge 833 commits into from
Closed

Fix 963 #1377

wants to merge 833 commits into from

Conversation

TC1977
Copy link
Contributor

@TC1977 TC1977 commented Mar 26, 2019

Description

Much pain and debugging of #963 over the last several months led me to conclude that the "Connecting..." loop is mainly one of outgoing policies not being deleted properly by strongSwan. It seems to happen most frequently when the client switches between Wi-Fi/LTE, often when there's a poor connection with either. The best way to resolve this may be to make the connection itself longer-lived, by changing settings on both the server and iOS/macOS side.

  • .mobileconfig settings restored to the Apple default of 1440m
  • server-side settings in /etc/ipsec.conf changed to lifetime=3h, ikelifetime=12h.
  • Settings in /etc/strongswan.d/charon.conf changed to close_ike_on_child_failure = yes, half_open_timeout = 5, inactivity_close_ike = yes, and (NAT) keep_alive = 25, reuse_ikesa = yes.

Motivation and Context

Makes strongSwan connections longer-lived, introduces charon.conf installation for future modifications if needed. Read the saga of #963 if you like.

How Has This Been Tested?

Ran Algo server since late November with the current configuration. No "unable to install policy...same policy for reqid xxx exists" errors. Today: cloud installed this branch from a Mac onto AWS, no installation errors, mobileconfigs appropriately modified, /etc/ipsec.conf and /etc/strongswan.d/charon.conf also appropriately installed. mobileconfig installed onto iPhone running 12.1.4, no issues, websites load successfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

cdolle and others added 30 commits July 8, 2017 14:36
…ts#655)

We're already doing it this way for CA_password, and ansible's to_uuid is problematic as it uses uuid v5 under the hood (trailofbits#654)
* add new Frankfurt zones to algo script and ansible docs
* backfill ansible docs for recently added GCP zones in London and Sydney
)

This buys us an extra 16bits of password guessing entropy by expanding the characterset from hex to [a-zA-Z0-9_@]
…bits#711)

* docs/client-linux.md housekeeping

* add fedora-workstation instructions to client-linx.md

* add deploy-from-fedora-workstation doc

* change client-linux.md to internal link

* add deploy-from-fedora-workstation links

* correct markup

* correct typo
* Update to deploy-to-ubuntu.md

A fresh install (Off CD / ISO) doesn't include python-pip or python virtualenv module.
The fixes above take care of the additional requirements, as well as updating pip.

* Update deploy-to-ubuntu.md

Fix Typo
`server_name` should be `gce_server_name` for Google Compute Engine
…ts#736)

* Update script to restart the dnsmasq service using systemctl(systemd) command instead of service(Upstart)

* Use  instead of legacy  REF: https://github.com/koalaman/shellcheck/wiki/SC2006

* Replace non-standard egrep(deprecated) for grep -E. REF: https://github.com/koalaman/shellcheck/wiki/SC2196
zesty is no longer available

disable ubuntu 17 at all
* Add cleanup step for SSH key.

* Two space tabs are hard to see.
build-essential and python-dev are required when compiling pycrypt. Added the necessary packages to the apt-get install line.
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 13 committers have signed the CLA.

✅ davidemyers
✅ luvpreetsingh
✅ selimsumlu
✅ jackivanov
✅ dguido
✅ bshiznit
✅ tho
✅ faf0
✅ TC1977
✅ adamluk
❌ thde
❌ akerl
❌ tc1977


tc1977 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

TC1977 and others added 7 commits March 26, 2019 13:56
Changes Child_SA lifetime to 2 hours, and IKE_SA lifetime to 12 hrs (Apple default is actually 12h for both).
Switching to inline rekeying from reauthentication, and lengthening child_SA and IKE_SA lifetimes.
Not sure why I had it at 120 for this. I'm running fine with both IKE lifetime and CHILD_SA lifetimes at 1440 (Apple default).
@TC1977
Copy link
Contributor Author

TC1977 commented Mar 26, 2019

So, I tried to rebase this and remove the commits by 'tc1977' (no idea why that happened), and it obviously didn't work. Help?

Changes Child_SA lifetime to 2 hours, and IKE_SA lifetime to 12 hrs (Apple default is actually 12h for both).
Switching to inline rekeying from reauthentication, and lengthening child_SA and IKE_SA lifetimes.
Not sure why I had it at 120 for this. I'm running fine with both IKE lifetime and CHILD_SA lifetimes at 1440 (Apple default).
@dguido dguido requested a review from jackivanov March 27, 2019 15:11
@TC1977 TC1977 mentioned this pull request Mar 27, 2019
4 tasks
@TC1977
Copy link
Contributor Author

TC1977 commented Mar 27, 2019

I was able to use force-push to sync my fork with upstream, but have no idea how to preserve these commits (and change the author). So I made a clean branch. See #1379.

@TC1977 TC1977 closed this Mar 27, 2019
@TC1977 TC1977 deleted the fix-963 branch March 27, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet