Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture return values in run.sh #1776

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Capture return values in run.sh #1776

merged 4 commits into from
Aug 4, 2020

Conversation

ehennenfent
Copy link
Contributor

Switching from YAML to a script means that individual steps can fail, but the tests will still pass if the return value of the entire script is okay.

@ehennenfent ehennenfent mentioned this pull request Jul 21, 2020
Merged
@ehennenfent ehennenfent marked this pull request as ready for review August 4, 2020 01:09
@ehennenfent
Copy link
Contributor Author

@feliam It looks like the NoAliveStates error was caused by the timeout firing somewhere in between the first and second call to m.transaction in verifier.py. I've "fixed" it by checking m.is_killed() in between and adding a break, but I'm not sure that'll stand up as a robust solution. Thoughts?

@feliam
Copy link
Contributor

feliam commented Aug 4, 2020

@feliam It looks like the NoAliveStates error was caused by the timeout firing somewhere in between the first and second call to m.transaction in verifier.py. I've "fixed" it by checking m.is_killed() in between and adding a break, but I'm not sure that'll stand up as a robust solution. Thoughts?

Yes I think it may be good enough!
I think that the states that are caught in a timeout/kill in the middle of an exploration are sent to a "killed" state list.
My current understanding is that it does not matter here because the property was tested before any symbolic transaction.

feliam
feliam approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@feliam feliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@ehennenfent ehennenfent merged commit 2159aa7 into master Aug 4, 2020
@ehennenfent ehennenfent deleted the fix-run_dot_sh branch August 4, 2020 16:17
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into capstone-5-dev
be00705 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
  Capture return values in run.sh (#1776)
  Create a model for strncpy (#1770)
  Add doc, fix output bugs (#1769)
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliam feliam feliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehennenfent @feliam