Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coveralls Take 2 #1784

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Coveralls Take 2 #1784

merged 8 commits into from
Aug 4, 2020

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Jul 31, 2020 •
edited

This branch needs to be on the main repo.

See #1783 for more details

If this is merged, it will invalidate #1778

@ekilmer ekilmer mentioned this pull request Jul 31, 2020
Closed
3 tasks
@ekilmer ekilmer requested a review from ehennenfent July 31, 2020 22:11
@ehennenfent ehennenfent added this to In progress in Manticore Aug 4, 2020
@ehennenfent ehennenfent moved this from In progress to Review in progress in Manticore Aug 4, 2020
@ehennenfent
Copy link
Contributor

Per discussion on the previous PR, I'd prefer a solution where we don't have to manually install coveralls, but as long as their GH action isn't working for us, this looks good to me.

Manticore automation moved this from Review in progress to Reviewer approved Aug 4, 2020
@ehennenfent ehennenfent merged commit 547a59c into master Aug 4, 2020
Manticore automation moved this from Reviewer approved to Done Aug 4, 2020
@ehennenfent ehennenfent deleted the coveralls branch August 4, 2020 22:36
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into simple-symbolic-syscalls
6433ec8 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into add-fdlike-stat
e0f0077 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into capstone-5-dev
be00705 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
  Capture return values in run.sh (#1776)
  Create a model for strncpy (#1770)
  Add doc, fix output bugs (#1769)
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into state-hooks
24a7877 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
ekilmer added a commit that referenced this pull request Aug 5, 2020
@ekilmer
Merge branch 'master' into multi-symbolic-socket-accept
8989185 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehennenfent ehennenfent ehennenfent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Manticore
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekilmer @ehennenfent