Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Add stat method for FdLike #1780

Merged
merged 10 commits into from Aug 11, 2020
Merged

Linux: Add stat method for FdLike #1780

merged 10 commits into from Aug 11, 2020

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Jul 29, 2020

This was missing previously but should be supported for anything that has a file descriptor.

bradlarsen
bradlarsen approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@bradlarsen bradlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I suggest giving the failing syscall return codes a second look.

manticore/platforms/linux.py Show resolved Hide resolved
@ehennenfent ehennenfent added this to In progress in Manticore Aug 4, 2020
@ehennenfent ehennenfent moved this from In progress to Review in progress in Manticore Aug 4, 2020
Eric Hennenfent and others added 2 commits August 4, 2020 15:35
Merge branch 'master' into add-fdlike-stat
b6c67c8
@ekilmer
Merge branch 'master' into add-fdlike-stat
e0f0077 
* master:
  Change the default to threading (#1779)
  Coveralls Take 2 (#1784)
Manticore automation moved this from Review in progress to Reviewer approved Aug 6, 2020
ehennenfent
ehennenfent approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one type hint I added as a nit. Thanks for putting this together.

manticore/platforms/linux.py Outdated Show resolved Hide resolved
manticore/platforms/linux.py Show resolved Hide resolved
ekilmer and others added 3 commits August 11, 2020 11:32
@ekilmer
Add typehint to Directory stat()
b6cce76 
Co-authored-by: Eric Hennenfent <eric.hennenfent@trailofbits.com>
@ekilmer
Fix typehints with os.stat
ba7934f
@ekilmer
Adjust type for stat object
10532f4
@ehennenfent ehennenfent merged commit 9b2c2f2 into master Aug 11, 2020
Manticore automation moved this from Reviewer approved to Done Aug 11, 2020
@ehennenfent ehennenfent deleted the add-fdlike-stat branch August 11, 2020 17:40
ekilmer added a commit that referenced this pull request Aug 11, 2020
@ekilmer
Merge branch 'master' into state-hooks
0fa5cc8 
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
ekilmer added a commit that referenced this pull request Aug 11, 2020
@ekilmer
Merge branch 'master' into multi-symbolic-socket-accept
5b3465f 
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
ekilmer added a commit that referenced this pull request Aug 11, 2020
@ekilmer
Merge branch 'master' into capstone-5-dev
85b3bbb 
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
@ekilmer ekilmer added this to Done in CHESS Sep 24, 2020
@ehennenfent ehennenfent mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradlarsen bradlarsen bradlarsen approved these changes

@ehennenfent ehennenfent ehennenfent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CHESS
Done
Manticore
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekilmer @bradlarsen @ehennenfent