Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default handler for symbolic system call arguments #1785

Merged
merged 5 commits into from
Aug 6, 2020

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Aug 3, 2020

This will only be called when there is an implementation of the system
call in the concrete Linux class and no implementation in the symbolic
SLinux.

The action is simply to concretize any found symbolic system call
arguments.

This should hopefully ease the use of Manticore when it encounters
symbolic arguments to system calls that don't have specially
implemented symbolic handling. A debug message is printed when this happens.

This will only be called when there is an implementation of the system
call in the concrete Linux class and no implementation in the symbolic
SLinux.

The action is simply to concretize any found symbolic system call
arguments.

This should hopefully ease the use of Manticore when it encounters
symbolic arguments to system calls that don't have specially implemented
symbolic handling. A debug message is printed when this happens.
@ehennenfent ehennenfent added this to In progress in Manticore Aug 4, 2020
@ehennenfent ehennenfent moved this from In progress to Review in progress in Manticore Aug 4, 2020
@sschriner sschriner self-requested a review August 4, 2020 21:59
Manticore automation moved this from Review in progress to Reviewer approved Aug 4, 2020
Copy link
Contributor

@sschriner sschriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@ehennenfent ehennenfent merged commit f20a011 into master Aug 6, 2020
Manticore automation moved this from Reviewer approved to Done Aug 6, 2020
@ehennenfent ehennenfent deleted the simple-symbolic-syscalls branch August 6, 2020 17:48
ekilmer added a commit that referenced this pull request Aug 11, 2020
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
ekilmer added a commit that referenced this pull request Aug 11, 2020
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
ekilmer added a commit that referenced this pull request Aug 11, 2020
* master:
  Linux: Add stat method for FdLike (#1780)
  Use default handler for symbolic system call arguments (#1785)
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
@ekilmer ekilmer added this to Done in CHESS Sep 24, 2020
@ehennenfent ehennenfent mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CHESS
Done
Manticore
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants