Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU detection within attacks #30

Closed
suhacker1 opened this issue Sep 24, 2020 · 0 comments · Fixed by #64
Closed

Add GPU detection within attacks #30

suhacker1 opened this issue Sep 24, 2020 · 0 comments · Fixed by #64
Labels
backend Backend improvements; may not directly impact user experience help wanted Extra attention is needed needs validation Some validation is required to document the solution tests

Comments

@suhacker1
Copy link
Collaborator

suhacker1 commented Sep 24, 2020

Is your feature request related to a problem? Please describe.
This should be integrated into all of the attacks. Users will no longer be required to explicitly state how many GPUs they are using. However, they should have the ability to do so. This should output something like:

GPU Available: True; GPU Used: False

This is motivated by the fact that the tests only work on a CPU due to GitHub Actions, so all tests must explicitly define that they are not using a GPU.

Describe the solution you'd like.
Explicit statements take priority over automated detection. This should turn off all GPU-specific behavior, especially .cuda methods.

Describe alternatives you've considered.
We could have separate tests on a GPU with a different CI. Self-hosted runners are not an option. We are open to alternatives.

Detail any additional context.
If you include a test for GPU behavior, it must be ignored by GitHub Actions somehow.

Potentially interesting links:

  1. How PyTorch Lightning became the first ML framework to run continuous integration on TPUs
  2. Effective testing for machine learning systems
@suhacker1 suhacker1 added tests backend Backend improvements; may not directly impact user experience needs validation Some validation is required to document the solution labels Sep 24, 2020
@suhacker1 suhacker1 added the help wanted Extra attention is needed label Dec 16, 2020
@suhacker1 suhacker1 linked a pull request Jan 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend improvements; may not directly impact user experience help wanted Extra attention is needed needs validation Some validation is required to document the solution tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant