Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Duplicate dependency detection across different chunks #3

Open
pjlee11 opened this issue Nov 23, 2020 · 0 comments
Open

Feature: Duplicate dependency detection across different chunks #3

pjlee11 opened this issue Nov 23, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pjlee11
Copy link

pjlee11 commented Nov 23, 2020

Currently webpack-bundle-delta detects duplicate dependencies when they are in the same chunk which is awesome, however it would be good to push this one step further with duplicate dependency detection across all chunks. This should be an opt-in feature behind a flag as by default not all applications would need it.

The idea behind this is that some complex applications will have chunks brought in by other chunks (EG: dynamic imports) which could end up with duplicate dependencies. Take the following example:

Example

// bundle-a.js
require.ensure('bundle-c.js');
deps: [
  'cool-dependency': ^2.6.0,
]

// bundle-b.js
require.ensure('bundle-c.js');
deps: [
  'cool-dependency': ^3.0.2,
]

// bundle-c.js
deps: [
  'cool-dependency': ^3.1.0,
]

Any page that uses bundle-a will have have cool-dependency@2.6.0 and cool-dependency@3.1.0 which we would want to know be reported on the PR.

@davidhouweling davidhouweling added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants