Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch reimplementation #37

Open
zhangmozhe opened this issue Apr 14, 2020 · 7 comments
Open

Pytorch reimplementation #37

zhangmozhe opened this issue Apr 14, 2020 · 7 comments

Comments

@zhangmozhe
Copy link

Hi, I really like this work. I just wonder whether you have the plan to reimplement it using Pytorch? Or release the pytorch pre-trained model?

@HoiM
Copy link

HoiM commented Jun 19, 2020

I am currently working on this project with PyTorch and PyTorch3D. Things are almost done except the settings of the camera so that the 8 transformation parameters can work with the rendered image. Now I hope the author could provide the parameters of the camera.

@invisprints
Copy link

@HoiM Hello, any progress?

@HoiM
Copy link

HoiM commented Jul 31, 2020

@HoiM Hello, any progress?

Got no reply from the author...

@invisprints
Copy link

invisprints commented Aug 26, 2020

@HoiM I am confused about the parameters of the camera you said. are they different from camera projection parameters?In the paper, it said "the camera projection parameters estimated by the encoder"

@chaoshiedwin
Copy link

I am currently working on this project with PyTorch and PyTorch3D. Things are almost done except the settings of the camera so that the 8 transformation parameters can work with the rendered image. Now I hope the author could provide the parameters of the camera.

Hi, did you find that the z-buffer kernel is not differentiable in the code? How can you resovle this problem with pytorch?

@HoiM
Copy link

HoiM commented Sep 16, 2020

@invisprints Maybe I was confused. The camera model used in the paper is weak perspective projection camera model. Based on my understanding, the 8 parameters can directly convert a 3D point to a plane. While in my implementation, I used the perspective projection camera model, where field of view, location of the camera in the world system, and the focal length must be set. Maybe the 8 parameters are already enough.

Please feel free to correct me if anything I said was wrong.

@HoiM
Copy link

HoiM commented Sep 16, 2020

@chaoshiedwin I switched to another work and successfully implemented the rendering process. Here the camera model is weak perspective model. But I used OpenGLPerspectiveCamera in PyTorch3D, where Z-buffer is not needed to be coded by hand.

Moreover, based on my understanding, z-buffer is more of like a mask where back-propagation is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants