-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go-vet shadow variable checking. #2042
Merged
Merged
Changes from 34 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
61d84c6
Add go-vet shadow variable checking.
e9503f5
Merge branch 'master' into cg_165129809_go_vet_shadow
9ad0a84
Fix shadow vars in internalapi
bc0840e
Fix shadow vars in publicapi
c894a6b
Fix shadow vars in milmove main
01b2ddc
Fix shadow vars in unit base quantity test
3eb752b
Fix shadow vars in generate test data script
4c1c98f
Fix shadow vars in process invoice service
d6a483b
Fix shadow vars in shipment services
405b6ea
Fix shadow vars in fuelprice storer service
af40fc5
Fix shadow vars in fuelprice storer service
866bfed
Fix shadow vars in fuelprice storer service test
5893c1b
Fix shadow vars in rateengine nonlinehaul
43adf08
Ignore swagger generated code
d6dfba3
Fix shadow vars in paperwork generator
b67aaf9
Fix shadow vars in awardqueue
a4ab593
Fix shadow vars in generate shipment edi
612bd03
Fix shadow vars in uploader
b4f1a5f
Fix shadow vars in awardqueue
7a78f14
Fix shadow vars in models
c668c0c
Fix shadow vars in auth cookies
e8529ff
Fix shadow vars in renderer
d066124
Fix shadow vars in health checker
3502d95
Fix shadow vars in ecs service logs
24717c0
Fix shadow variables in awardqueue
f639364
Fix formatting
31a1c10
Modify script to work from any directory in the project
5bbaca1
No need to ignore vendor directory anymore
85702f6
Simplify getting directory, make readonly
13af5cc
Merge branch 'master' into cg_165129809_go_vet_shadow
ef699b6
Deploy to experimental
c5cc4fe
Revert "Deploy to experimental"
69759db
Merge master
2517d3b
Merge master
fb74b6b
Remove extra gosec
c68a39e
Merge branch 'master' into cg_165129809_go_vet_shadow
13948d1
Merge branch 'master' into cg_165129809_go_vet_shadow
fcaf2b9
Merge branch 'master' into cg_165129809_go_vet_shadow
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjdufour-truss - found this shadow variable and was hoping you'd take a look at it. I think I made the appropriate fix.