Add test for changing content of Qt linguist files #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your test doesn't pass. Can you look into it? |
|
Hmm looks like old lxml is causing this difference... |
|
@nijel: This won't get into 1.12.0-rc1, but might get into the stable 1.12.0 if it gets fixed. |
|
Fixed and rebased now. |
|
Okay, I've raised the lxml requirement, now it works. But the test suite fails on same errors as upstream... |
|
@nijel Fixed the test suite in master. Can you quickly rebase this and re-push in order to verify that everything is green? |
It tests whether file is properly changed and the flag is correctly set.
Signed-off-by: Michal Čihař <michal@cihar.com>
|
Rebased. |
|
Merged in master. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It tests whether file is properly changed and the flag is correctly set.