-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IE polyfills and special casing #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document a list of all the polyfills required for IE somewhere? README or in the docs. I think it would save a lot of figuring out for people that do still need to support it.
We should have a 1.0->2.0 migration guide (separate, or inlined with the announcement post), that lists all of these. I think it also makes sense to mirror the required polyfills to the general docs after that yes. It's never to soon to start tracking them in a central place indeed, wherever we end up copying it. Perhaps, the 2.0 branch can already contain a WIP post, and we keep a bullet list of these. Each PR that introduces new requirements bundles with it addition(s) to that list. By the time we're ready all that's left to do is cleanup the language and decide where else to publish. |
6e8e168
to
1d8bce1
Compare
`platform` doesn't seem to be a valid key, it's probably ignored. Refs: https://w3c.github.io/webdriver/#capabilities
5e7678e
to
3a32e2b
Compare
PR update:
E2E tests are failing in Safari now, not sure if it's a flakiness of the CI or a real issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks good but maybe @goto-bus-stop has an opinion on the bundling stuff.
would just "uppy.legacy.js" be good or would you prefer something more specific? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think in the final blog post it would be good to make it extra clear that we used to include these polyfills always, so it's not like you suddenly need 20KB of polyfills that you didn't before; it's just that we always included them in the past and we now let you omit them if you don't need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two inconsequential things ^^
Co-authored-by: Renée Kooi <renee@kooi.me>
IE users would need to include
abortcontroller-polyfill
,math-log2
, andurl-polyfill
from npm.