meta: use a single .env file for config
#3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: transloadit#3473 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Mikael Finstad <finstaden@gmail.com>
mifi
reviewed
Feb 17, 2022
| @@ -25,7 +25,7 @@ import DropTarget from '@uppy/drop-target' | |||
| import Audio from '@uppy/audio' | |||
| /* eslint-enable import/no-extraneous-dependencies */ | |||
|
|
|||
| // DEV CONFIG: create a .env.local file to customize those values. | |||
| // DEV CONFIG: create a .env file in the project root directory to customize those values. | |||
| set +a | ||
| nodemon --watch packages/@uppy/companion/src --exec node ./packages/@uppy/companion/src/standalone/start-server.js | ||
| if [ -f .env ]; then | ||
| nodemon --watch packages/@uppy/companion/src --exec node -r dotenv/config ./packages/@uppy/companion/src/standalone/start-server.js |
There was a problem hiding this comment.
nice trick. did you test this locally with npm run start:companion?
There was a problem hiding this comment.
Yes looks like it's working
Co-authored-by: Mikael Finstad <finstaden@gmail.com>
mifi
approved these changes
Feb 17, 2022
Merged
github-actions bot
added a commit
that referenced
this pull request
Feb 17, 2022
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/companion | 3.3.0 | uppy | 2.6.0 | | @uppy/robodog | 2.3.2 | | | - meta: warn about not merging PR manually (Artur Paikin / #3492) - @uppy/companion: fix unpslash author meta, sanitize metadata to strings and improve companion tests (Mikael Finstad / #3478) - meta: ensure README is correctly formatted when doing releases (Antoine du Hamel / #3499) - meta: fix CDN bundle (Antoine du Hamel / #3494) - meta: fix missing EOL and end of e2e test templates (Antoine du Hamel / #3484) - meta: use a single `.env` file for config (Antoine du Hamel / #3498)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/companion | 3.3.0 | uppy | 2.6.0 | | @uppy/robodog | 2.3.2 | | | - meta: warn about not merging PR manually (Artur Paikin / transloadit#3492) - @uppy/companion: fix unpslash author meta, sanitize metadata to strings and improve companion tests (Mikael Finstad / transloadit#3478) - meta: ensure README is correctly formatted when doing releases (Antoine du Hamel / transloadit#3499) - meta: fix CDN bundle (Antoine du Hamel / transloadit#3494) - meta: fix missing EOL and end of e2e test templates (Antoine du Hamel / transloadit#3484) - meta: use a single `.env` file for config (Antoine du Hamel / transloadit#3498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3473
Refs: #3478 (comment)