Build error: third-party/fmt/include/fmt/core.h: error: expected unqualified-id before '>=' token #5627
Labels
Milestone
Comments
|
We're using fmt 9.0.0. Related transmission issue: #5511 |
|
@Coeur Can Transmission be configured to use external |
|
@barracuda156 currently the only include path that CMake scripts look for |
BTW, |
ckerr
added a commit
that referenced
this issue
Jun 18, 2023
|
@ckerr Thank you, I will try it out now. |
|
@ckerr Unfortunately, the issue still there: At the same time, standalone |
|
Maybe some flags are breaking this? |
|
@barracuda156 what happens if you clone out https://github.com/fmtlib/fmt directly from github and try to build it without any Transmission involved in the mix? |
|
@ckerr 10.0.0 builds perfectly fine from this: https://github.com/macports/macports-ports/blob/472983556a56d166ef67420bf8575aa247c91b01/devel/libfmt10/Portfile Do you want me to check specifically the latest commit build? |
|
A quick update: I could not get GUI running straightaway, but CLI is working fine. |
|
🤔 @barracuda156 I wonder why the version in macports is building but not here. Just as you say, maybe some flags are breaking this here. Maybe compare what flags we're using vs macports and then iterate through the differences to find which one breaks? I'm supportive in spirit but since I don't have access to a Mac right now @barracuda156 you'll probably need to do the legwork on tracking this down... |
|
@ckerr It appears that this is largely inconsequential – Not sure why GUI fails, though not really surprised either. (Nobody tests, so why would it work correctly?) On a side note, |
I don't understand the question -- if you're talking about GTK vs Qt, of course there is a version of Transmission written in Qt in the qt/ directory 😸 But if you mean specifically Qt4 ... is there a compelling reason to use that vs Qt5 or Qt6? Qt4 is no longer maintained -- its support ended in 2015 -- and transmission-qt works with both Qt5 and Qt6. (Side note: Looks like even Qt5 is falling by the wayside; its LTS support ended last month and KDE is working towards going to a Qt6-only release) |
|
@ckerr I have seen it, as well as that it specifies Qt5+. If no requirement was there, I would have tried building straightaway. |
|
I'm not aware that Qt5+ would be broken: apart from our own Transmission client, there is a popular BitTorrent client entirely for Qt5 and Qt6 which is working well on macOS: https://github.com/qbittorrent/qBittorrent/ [edit] |
|
@barracuda156 I don't think it makes sense for Transmission to support Qt4 since it's been unsupported upstream for 7 years. If you want to do the work to re-add Qt4 support and if the diff is small I'd be willing to consider including it for unofficial support, e.g. "we won't take bug reports but the code at least builds". But surely just using GTK would be a simpler option 😸 |
|
@ckerr Thank you. Yes, I perfectly understand that no one is gonna take an extra burden to support it. I rather was asking for a subjective opinion or possibly technical advice if restoring support for Qt4 is feasible (in a sense of reverting some commits). If it is 8000 LOC scattered here and there, obviously, it would be a no-go – I have better things to waste my time on :) @Coeur There are specific things which are a trouble for PowerPC systems. Many things do work on par with modern systems (obviously, save for speed). But yeah, Qt is one big pain. |
ckerr
added a commit
that referenced
this issue
Jun 19, 2023
commit 4b9b992 Author: Charles Kerr <charles@charleskerr.com> Date: Mon Jun 19 16:51:34 2023 -0500 refactor: prefer std::map over QMap in transmission-qt (#5641) * refactor: use std::map instead of QMap in PrefsDialog.cc * refactor: use std::map instead of QMap in DetailsDialog.cc * refactor: use std::map instead of QMap in OptionsDialog.cc * refactor: use std::map instead of QMap in FileTreeModel.cc commit 040bc8a Author: Dmitry Antipov <dmantipov@yandex.ru> Date: Tue Jun 20 00:22:54 2023 +0300 fix: Qt 6.5 deprecation warning (#5552) commit 23a52fa Author: LaserEyess <16581533+LaserEyess@users.noreply.github.com> Date: Mon Jun 19 16:51:20 2023 -0400 fixup: dedup tr_rpc_address with tr_address (#5523) * fixup: dedup tr_rpc_address with tr_address tr_rpc_address was duplicating a lot of work that tr_address was doing a lot better. Fall back to using tr_address for ipv4/ipv6 connections and make a tr_unix_addr for handling unix sockets. * remove unnecessary functions commit ddac059 Author: Василий Чай <basilefff@gmail.com> Date: Mon Jun 19 09:30:55 2023 +0400 fix: return error when renaming into existing file (#5563) commit b8ff35c Author: tearfur <46261767+tearfur@users.noreply.github.com> Date: Mon Jun 19 08:06:31 2023 +0800 handle IPv6 NAT during LTEP handshake (#5565) * fix: peer handshake reported wrong ipv6 address #5542 (comment) commit fd583ac Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 18 17:36:39 2023 -0500 deps: bump libfmt to v10.0.0 (#5635) seems to be semver/minor safe for our API use Fixes #5511. Possibly fixes #5627. commit 1664088 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun Jun 18 15:55:43 2023 -0500 chore: update generated transmission-web files (#5588) commit 0fd7989 Author: Gary Elshaw <69029666+GaryElshaw@users.noreply.github.com> Date: Mon Jun 19 07:11:56 2023 +1200 fix: restore png files that were corrupted in recent "compression" script commit bd9d110 Author: Cœur <coeur@gmx.fr> Date: Sun Jun 18 20:32:34 2023 +0200 fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 (#5633) commit 76166d8 Author: Cœur <coeur@gmx.fr> Date: Mon Jun 12 18:03:22 2023 +0200 refactor: replace NSMutableDictionary with constant attributes (#5221) commit c379cd7 Author: Robin Seth Ekman <robin.seth.ekman@gmail.com> Date: Mon Jun 12 03:19:54 2023 +0200 fix: transmission-remote only list every other label (fixes #5571) (#5572) commit 87f254a Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 18:52:45 2023 -0500 chore: bump fast_float snaapshot to 5.2.0 (#5605) commit 802619e Author: tearfur <46261767+tearfur@users.noreply.github.com> Date: Mon Jun 12 07:27:01 2023 +0800 fix: fixes and improvements to global IP query (#5510) commit c8e84f8 Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 16:28:43 2023 -0500 ci: remove "brew update" step (#5606) commit 60c68af Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 11:25:35 2023 -0500 Revert "fix: some labels not displayed in transmission-remote (#5600)" This reverts commit ebd5080. commit ebd5080 Author: Charles Kerr <charles@charleskerr.com> Date: Sat Jun 10 19:01:32 2023 -0500 fix: some labels not displayed in transmission-remote (#5600) Fixes #5571. commit 8ca02b8 Author: Mike Gelfand <mikedld@users.noreply.github.com> Date: Sun Jun 11 02:09:18 2023 +0400 Avoid locale use in `tr_truncd()` (#5587) `tr_parseNum<>()` is implemented with `fast_float::from_chars()`, and the latter is documented as "expecting a locale-indepent format equivalent to what is used by std::strtod in the default ("C") locale". To accomodate locale independent number parsing, switch back to locale-independent number formatting in `tr_truncd()` by both removing a `L` format specifier from `fmt::format_to_n()` call and using a fixed "." decimal separator when truncating the value. commit 0ef58c2 Author: Charles Kerr <charles@charleskerr.com> Date: Mon Jun 5 17:03:11 2023 -0500 chore: improve lossless compression of png files (#5586) commit c1c27f3 Author: Daniel Kamil Kozar <dkk089@gmail.com> Date: Mon Jun 5 20:15:32 2023 +0200 Expose files' begin and end pieces via RPC (#5578) * Expose files' begin and end pieces via RPC This adds two arguments, `beginPiece` and `endPiece`, for each of the entries in the `files` array of the RPC's `torrent-`get` method. The point is to allow RPC clients to display a file's completion progress as piece-based in addition to byte-based. commit 61679e1 Author: Cœur <coeur@gmx.fr> Date: Mon May 29 15:43:43 2023 +0200 Support localized punctuation for "Port:" (#4452) * Support localized punctuation for "Port:" * Code review: adopting "Port: %@" * updating other locales for "Port" -> "Port: %@"
Maybe so. My guess is that a patch to get transmission-qt building in Qt4 wouldn't be insanely large. We don't use a lot of the newer features and so most of the work would probably be just |
|
@ckerr @Coeur Found the log of |
|
@barracuda156 maybe file that in a separate ticket? Reporting a transmission-gtk crash inside a "fmt fails to compile" issue is difficult from an issue management & discoverability standpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the issue?
gcc 12.3.0
Which application of Transmission?
Which version of Transmission?
4.0.3
The text was updated successfully, but these errors were encountered: