fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Coeur
commented
Jun 18, 2023
Coeur
commented
ckerr
approved these changes
Jun 18, 2023
|
Notes: Updated code that had been using deprecated API. |
ckerr
pushed a commit
that referenced
this pull request
Jun 18, 2023
ckerr
added a commit
that referenced
this pull request
Jun 19, 2023
commit 4b9b992 Author: Charles Kerr <charles@charleskerr.com> Date: Mon Jun 19 16:51:34 2023 -0500 refactor: prefer std::map over QMap in transmission-qt (#5641) * refactor: use std::map instead of QMap in PrefsDialog.cc * refactor: use std::map instead of QMap in DetailsDialog.cc * refactor: use std::map instead of QMap in OptionsDialog.cc * refactor: use std::map instead of QMap in FileTreeModel.cc commit 040bc8a Author: Dmitry Antipov <dmantipov@yandex.ru> Date: Tue Jun 20 00:22:54 2023 +0300 fix: Qt 6.5 deprecation warning (#5552) commit 23a52fa Author: LaserEyess <16581533+LaserEyess@users.noreply.github.com> Date: Mon Jun 19 16:51:20 2023 -0400 fixup: dedup tr_rpc_address with tr_address (#5523) * fixup: dedup tr_rpc_address with tr_address tr_rpc_address was duplicating a lot of work that tr_address was doing a lot better. Fall back to using tr_address for ipv4/ipv6 connections and make a tr_unix_addr for handling unix sockets. * remove unnecessary functions commit ddac059 Author: Василий Чай <basilefff@gmail.com> Date: Mon Jun 19 09:30:55 2023 +0400 fix: return error when renaming into existing file (#5563) commit b8ff35c Author: tearfur <46261767+tearfur@users.noreply.github.com> Date: Mon Jun 19 08:06:31 2023 +0800 handle IPv6 NAT during LTEP handshake (#5565) * fix: peer handshake reported wrong ipv6 address #5542 (comment) commit fd583ac Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 18 17:36:39 2023 -0500 deps: bump libfmt to v10.0.0 (#5635) seems to be semver/minor safe for our API use Fixes #5511. Possibly fixes #5627. commit 1664088 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun Jun 18 15:55:43 2023 -0500 chore: update generated transmission-web files (#5588) commit 0fd7989 Author: Gary Elshaw <69029666+GaryElshaw@users.noreply.github.com> Date: Mon Jun 19 07:11:56 2023 +1200 fix: restore png files that were corrupted in recent "compression" script commit bd9d110 Author: Cœur <coeur@gmx.fr> Date: Sun Jun 18 20:32:34 2023 +0200 fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 (#5633) commit 76166d8 Author: Cœur <coeur@gmx.fr> Date: Mon Jun 12 18:03:22 2023 +0200 refactor: replace NSMutableDictionary with constant attributes (#5221) commit c379cd7 Author: Robin Seth Ekman <robin.seth.ekman@gmail.com> Date: Mon Jun 12 03:19:54 2023 +0200 fix: transmission-remote only list every other label (fixes #5571) (#5572) commit 87f254a Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 18:52:45 2023 -0500 chore: bump fast_float snaapshot to 5.2.0 (#5605) commit 802619e Author: tearfur <46261767+tearfur@users.noreply.github.com> Date: Mon Jun 12 07:27:01 2023 +0800 fix: fixes and improvements to global IP query (#5510) commit c8e84f8 Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 16:28:43 2023 -0500 ci: remove "brew update" step (#5606) commit 60c68af Author: Charles Kerr <charles@charleskerr.com> Date: Sun Jun 11 11:25:35 2023 -0500 Revert "fix: some labels not displayed in transmission-remote (#5600)" This reverts commit ebd5080. commit ebd5080 Author: Charles Kerr <charles@charleskerr.com> Date: Sat Jun 10 19:01:32 2023 -0500 fix: some labels not displayed in transmission-remote (#5600) Fixes #5571. commit 8ca02b8 Author: Mike Gelfand <mikedld@users.noreply.github.com> Date: Sun Jun 11 02:09:18 2023 +0400 Avoid locale use in `tr_truncd()` (#5587) `tr_parseNum<>()` is implemented with `fast_float::from_chars()`, and the latter is documented as "expecting a locale-indepent format equivalent to what is used by std::strtod in the default ("C") locale". To accomodate locale independent number parsing, switch back to locale-independent number formatting in `tr_truncd()` by both removing a `L` format specifier from `fmt::format_to_n()` call and using a fixed "." decimal separator when truncating the value. commit 0ef58c2 Author: Charles Kerr <charles@charleskerr.com> Date: Mon Jun 5 17:03:11 2023 -0500 chore: improve lossless compression of png files (#5586) commit c1c27f3 Author: Daniel Kamil Kozar <dkk089@gmail.com> Date: Mon Jun 5 20:15:32 2023 +0200 Expose files' begin and end pieces via RPC (#5578) * Expose files' begin and end pieces via RPC This adds two arguments, `beginPiece` and `endPiece`, for each of the entries in the `files` array of the RPC's `torrent-`get` method. The point is to allow RPC clients to display a file's completion progress as piece-based in addition to byte-based. commit 61679e1 Author: Cœur <coeur@gmx.fr> Date: Mon May 29 15:43:43 2023 +0200 Support localized punctuation for "Port:" (#4452) * Support localized punctuation for "Port:" * Code review: adopting "Port: %@" * updating other locales for "Port" -> "Port: %@"
mtremer
pushed a commit
to ipfire/ipfire-2.x
that referenced
this pull request
Aug 30, 2023
- Update from version 4.0.3 to 4.0.4 - Update of rootfile not required. - Changelog Transmission 4.0.4 This is a bugfix-only release. Everyone's feedback on 4.0.x has been very helpful -- thanks for all the suggestions, bug reports, and pull requests! What's New in 4.0.4 All Platforms * Fixed bug in sending torrent metadata to peers. ([#5460](transmission/transmission#5460)) * Avoid unnecessary heap memory allocations. ([#5520](transmission/transmission#5520), [#5527](transmission/transmission#5527)) * Fixed filename collision edge case when renaming files. ([#5563](transmission/transmission#5563)) * Fixed locale errors that broke number rounding when displaying statistics, e.g. upload / download ratios. ([#5587](transmission/transmission#5587)) * Always use a fixed-length key query in tracker announces. This isn't required by the [spec](https://www.bittorrent.org/beps/bep_0007.html), but some trackers rely on that fixed length because it's common practice by other BitTorrent clients. ([#5652](transmission/transmission#5652)) * Fixed potential Windows crash when [getstdhandle()](https://learn.microsoft.com/en-us/windows/console/getstdhandle) returns `NULL`. ([#5675](transmission/transmission#5675)) * Fixed `4.0.0` bug where the port numbers in LDP announces are sometimes malformed. ([#5825](transmission/transmission#5825)) * Fixed a bug that prevented editing the query part of a tracker URL. ([#5871](transmission/transmission#5871)) * Fixed a bug where Transmission may not announce LPD on its listening interface. ([#5896](transmission/transmission#5896)) * Made small performance improvements in libtransmission. ([#5715](transmission/transmission#5715)) macOS Client * Updated code that had been using deprecated API. ([#5633](transmission/transmission#5633)) Qt Client * Fixed torrent name rendering when showing magnet links in compact view. ([#5491](transmission/transmission#5491)) * Fixed bug that broke the "Move torrent file to trash" setting. ([#5505](transmission/transmission#5505)) * Fixed Qt 6.4 deprecation warning. ([#5552](transmission/transmission#5552)) * Fixed poor resolution of Qt application icon. ([#5570](transmission/transmission#5570)) GTK Client * Fixed missing 'Remove torrent' tooltip. ([#5777](transmission/transmission#5777)) Web Client * Don't show `null` as a tier name in the inspector's tier list. ([#5462](transmission/transmission#5462)) * Fixed truncated play / pause icons. ([#5771](transmission/transmission#5771)) * Fixed overflow when rendering peer lists and made speed indicators honor `prefers-color-scheme` media queries. ([#5814](transmission/transmission#5814)) * Made the main menu accessible even on smaller displays. ([#5827](transmission/transmission#5827)) transmission-cli * Fixed "no such file or directory" warning when adding a magnet link. ([#5426](transmission/transmission#5426)) * Fixed bug that caused the wrong decimal separator to be used in some locales. ([#5444](transmission/transmission#5444)) transmission-remote * Fixed display bug that failed to show some torrent labels. ([#5572](transmission/transmission#5572)) Everything Else * Ran all PNG files through lossless compressors to make them smaller. ([#5586](transmission/transmission#5586)) * Fixed potential build issue when compiling on macOS with gcc. ([#5632](transmission/transmission#5632)) Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
tearfur
added a commit
to tearfur/transmission
that referenced
this pull request
Sep 1, 2023
…S 10.14 (transmission#5633)" This reverts commit 90f8db7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.