Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback Hotkey is still being executed while looking up lyric #82

Closed
nattadasu opened this issue May 24, 2024 · 3 comments
Closed

Playback Hotkey is still being executed while looking up lyric #82

nattadasu opened this issue May 24, 2024 · 3 comments

Comments

@nattadasu
Copy link

nattadasu commented May 24, 2024

It seems that hotkey event listener (implemented in fcfd2ea) does not get disable in lyric lookup/search modal/popup.

Additionally, I found weird bug before I want to submit the issue related to this; the listener wasn't doing properly, it affected while editing the lyric too. But managed to "fix" it by simply restarting the app.

Steps to Reproduce

  1. Update local music database
  2. Select random file, either unsync, sync, or none
  3. Open search modal
  4. Keysmash Space in text fields

Expected result

User is able to input whitespace without making the app plays/pauses the file

Actual result

  • When debugger > console enabled, app does not log "enabled hotkey!" or "disabled hotkey!" during the modal opened.
  • However, if debugger window opened before, opening the modal returns "is hotkey: true" instead

System Info

  • App version: 0.3.1
  • Windows: 11, 23H2
@tranxuanthang
Copy link
Owner

I see, I remember I did fix it for lyrics editor modal, but I forgot the lyrics search one.

I will make a hotfix release, but I wonder if there is a global way to do this. For example, it should automatically disable hotkey detection when focusing on any kind of textbox.

@tranxuanthang
Copy link
Owner

I released the fix in 0.3.2 version. Could you help me verify it?

@nattadasu
Copy link
Author

Aight, I've upgraded to https://github.com/tranxuanthang/lrcget/releases/tag/0.3.2 and it works great now.

Thanks for the hotfix! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants