Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy pointer arithmetic warning #57

Closed
martinjrobins opened this issue Jul 6, 2018 · 2 comments
Closed

clang-tidy pointer arithmetic warning #57

martinjrobins opened this issue Jul 6, 2018 · 2 comments
Labels
question Further information is requested

Comments

@martinjrobins
Copy link
Collaborator

do we want to turn off this warning @fcooper8472 , seems like pointer arithmetic is kinda essential for an iterator!

/home/travis/build/trase-cpp/trase/src/util/ColumnIterator.hpp:92:26: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
  void increment() { m_p += m_stride; }
@martinjrobins martinjrobins added the question Further information is requested label Jul 6, 2018
@fcooper8472
Copy link
Collaborator

I think this ought to be resolved by #67. Are you happy with this @martinjrobins?

@martinjrobins
Copy link
Collaborator Author

yup, closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinjrobins @fcooper8472