Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spendwise: authentification, authorization, categorie page and payment page #7

Merged
merged 39 commits into from
May 2, 2023

Conversation

Trast00
Copy link
Owner

@Trast00 Trast00 commented May 2, 2023

In this pull request, I have been able to:

  • Add splash page
  • Add authentication with devise
  • Add authorization with CanCanCan
  • Add categories pages
    • Add categories model
    • Add categorie#index route and view
    • Add category #new route and view
  • Add payment pages
    • Add payment#index route and view
    • Add payment#new route and view
  • Add unit and integration test for main components

Here is the Live Demo Link and the presentation video here

Trast00 and others added 30 commits May 1, 2023 08:57
Setup rails repo with config
Add authentification with devise
Add categorie and payement models and controllers
Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: APPROVED 🟢 🟢 🟢

Hi @Trast00,

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉

Highlights:

✅ You used Gitflow correctly 👍🏽
✅ The Linter checks passed successfully 👍🏽
✅ Tests were implemented correctly and all simulation tests passed 👍🏽
✅ The app runs successfully and the design looks elegant as expected 👍🏽
✅ The Live and local versions of the app work fine 👍🏽
✅ Good descriptive PR 👍🏽
✅ Good commit messages 👍🏽
✅ Great video presentation 👍🏽

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Trast00 Trast00 merged commit eaca73c into main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants