More cache clarification #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #416
|
Also, #357, thank you! 🎉 |
|
Yes, I knew I remembered something about Docker, but was struggling to track it down. The comment was not on a PR but on a commit I think. |
MariadeAnton
reviewed
Jan 9, 2017
|
|
||
| * If a repository has *Build pushes* set to *OFF*, neither the target branch nor the master branch can ever be cached. | ||
| * If the cache found is old, for example in a workflow where most work happens on branches, the less useful the cache will be. | ||
| * If the cache on the master branch is old, for example in a workflow where most work happens on branches, the less useful the cache will be. | ||
| * If a pull request has a cache, to clear that cache you need to clear **both** the pull request cache **and** the cache of the target branch. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #416
I think this covers it. @MariadeAnton want to confirm?