Include submodule files in files_to_pack

[jdub]

By default, git ls-files does not include submodule files. Add --recurse-submodules to ensure they're included, which seems like a pretty reasonable default. Fixes #592.

[BanzaiMan]

Sorry for the long delay. Could you provide a link to a test deployment with this code?

Thank you!

[BanzaiMan]

Please test this with:

deploy:
  provider: elasticbeanstalk
  edge:
    branch: eb-updates
  ⋮ # rest

[jdub]

I've changed jobs and no longer have access to a good practical example. Hopefully an issue watcher could try this out.

[ashenm]

The following reproduce followed by the archive listings of builds was run against the latest version of dpl-elastic_beanstalk (1.10.11) and the PR commit c692056.

ubuntu@534d98a55c8d:~/workspace/assessment$ git ls-files --recurse-submodules
.gitmodules
a
b/b
submodule/.gitmodules
submodule/c
submodule/subsub/d

ubuntu@534d98a55c8d:~/workspace/assessment$ unzip -l travis-838a5fb0d8dd62c006b32cee1fdfe1359da79b79-1559820067.zip
Archive:  travis-838a5fb0d8dd62c006b32cee1fdfe1359da79b79-1559820067.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
       61  2019-06-06 11:21   .gitmodules
        2  2019-06-06 11:21   a
        2  2019-06-06 11:21   b/b
        0  2019-06-06 11:21   submodule/
---------                     -------
       65                     4 files

ubuntu@534d98a55c8d:~/workspace/assessment$ unzip -l travis-838a5fb0d8dd62c006b32cee1fdfe1359da79b79-1559820242.zip
Archive:  travis-838a5fb0d8dd62c006b32cee1fdfe1359da79b79-1559820242.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
       61  2019-06-06 11:24   .gitmodules
        2  2019-06-06 11:24   a
        2  2019-06-06 11:24   b/b
       52  2019-06-06 11:24   submodule/.gitmodules
        2  2019-06-06 11:24   submodule/c
        2  2019-06-06 11:24   submodule/subsub/d
---------                     -------
      121                     6 files

[svenfuchs]

Hey @jdub 👋

We are working on releasing a new major version dpl v2. The respective branch has been merged to master, and we are planning on releasing a developer preview, as well as a blog post soon, hopefully later this week.

I have ported your work on this branch to a new PR here: #1029. I believe this should be equivalent to your work.

If you would like me to amend the commit in order to add your Git user name and email address please let me know. (My commit was based on your work, so I would happily pass authorship for it, but I also did not want to presume.)

It would be great if you could help us test if the issue that your change was meant to address. You can opt into using dpl v2 by adding this to your .travis.yml file:

deploy:
  provider: [provider-name]
  edge:
    branch: master
⋮

Thank you!

[jdub]

Sorry @svenfuchs, I've changed jobs and no longer have access to a good practical example. Totally happy for you to take the credit for the port. :-)

[svenfuchs]

Alright, cool. Thank you @jdub!

@ashenm do you maybe have a practical example to test this on? #593 (comment)

if you do, let's continue the conversation on #1029. i'm going to close this PR here.