Provide built-in Godep support #309

zackkitzmiller · 2014-10-18T14:36:57Z

As suggested by Josh Kalderimis here.

BanzaiMan · 2014-10-18T15:11:40Z

@meatballhat Could you take a look at this one when you get a chance?

lib/travis/build/script/go.rb

@@ -33,6 +33,7 @@ def setup
          # easier to find and our `git clone`'d libraries are found by the
          # `go` commands.
          set 'GOPATH', "#{HOME_DIR}/gopath:$GOPATH"
+          set 'PATH', "$PATH:$GOPATH/bin"


zackkitzmiller · 2014-10-19T13:16:52Z

I'm actually not convinced that this works. A failure occurs in a .travis.yml that looks like this:

language: go

go: 1.3.1

install:
  - go get github.com/tools/godep
  - godep restore

script:
  - go test
  - test -z "$(go fmt ./...)"

It has to be modified to include $PATH=$PATH:$GOPATH/bin before it can find the godep command.

meatballhat · 2014-10-19T13:40:42Z

I think the go defaults should be modified to prepend ~/gopath/bin to
$PATH, given we're already setting ~/gopath to be the first entry in
$GOPATH. I've consistently had to do this prepending myself when
installing things like godep and using them without fully qualifying the
executable path.
On Oct 19, 2014 9:16 AM, "Zack Kitzmiller" notifications@github.com wrote:

I'm actually not convinced that this works. A failure occurs in a
.travis.yml that looks like this:

language: go
go: 1.3.1
install:

go get github.com/tools/godep

godep restore
script:

go test

test -z "$(go fmt ./...)"

It has to be modified to include $PATH=$PATH:$GOPATH/bin before it can
find the godep command.

—
Reply to this email directly or view it on GitHub
#309 (comment)
.

zackkitzmiller · 2014-10-19T13:42:42Z

@meatballhat This PR adds $GOPATH/bin to $PATH as a default. Is that not he behavior that you'd like. If not, can you let me know how you'd like it to look, and I can modify it.

zackkitzmiller · 2014-10-19T13:48:20Z

I've adjusted the PATH as recommended.

lib/travis/build/script/go.rb

@@ -41,6 +42,10 @@ def setup

        def install
          uses_make? then: 'true', else: "#{go_get} #{gobuild_args} ./...", fold: 'install', retry: true
+          self.if '-f Godeps/Godeps.json' do |sub|
+              sub.cmd "#{go_get} github.com/tools/godep", echo: true, retry: true, timing: true, assert: true
+              sub.cmd "godep restore", retry: true, timing: true, assert: true, echo: true


meatballhat · 2014-10-19T14:59:53Z

w00t! Merging this now + deploying to staging.

Provide built-in Godep support

meatballhat · 2014-10-19T15:07:54Z

Appears to work 👏 https://staging.travis-ci.org/meatballhat/yolo-octo-adventure/jobs/392466

@joshk @BanzaiMan any opinions on the UX? Any folds necessary?

meatballhat · 2014-10-19T15:11:21Z

Looks like we need to disable this below go1.1: https://staging.travis-ci.org/meatballhat/yolo-octo-adventure/jobs/392469

meatballhat · 2014-10-19T15:12:08Z

@zackkitzmiller I need to get back to GiveCamp. Any chance you can submit a follow up PR to disable when the version is under 1.1?

zackkitzmiller · 2014-10-19T15:16:39Z

Will do. Need about an hour, I'm out at the moment.

meatballhat · 2014-10-19T15:17:46Z

@zackkitzmiller 👍 thank you!

zackkitzmiller · 2014-10-19T18:57:23Z

Made a new PR. Thanks guys.

meatballhat · 2014-10-19T20:18:51Z

Looks happy in staging now: https://staging.travis-ci.org/meatballhat/yolo-octo-adventure/builds/392468

kr · 2014-10-19T22:04:01Z

Hey, I'm a little late here, but I think it would be better to edit $GOPATH to put $PROJECT/Godeps/_workspace in the front, and not run godep restore. (You don't even need godep installed or available to do this.) This is why we vendor the code, so you don't have to fetch it off the internet every time.

meatballhat · 2014-10-19T22:22:03Z

@kr I'm a fan 👍 @zackkitzmiller willing to PR it up? 😺

kr · 2014-10-19T22:24:51Z

Oh and regardless of my previous comment, thanks so much for doing this!!! So awesome. :)

zackkitzmiller · 2014-10-19T23:27:43Z

Hey all, so I think that's a great option, and we should add it, but there are a lot of people that have a .gitignore that looks like this:

Godeps/*
!Godeps/Godeps.json

And while several project do vendor everything, not all do. Can we come up with a solution that satisfies everyone?

kr · 2014-10-19T23:30:41Z

Personally I would rather not encourage that sort of gitignore, so I suggest not adding code to accommodate it. But I understand if you want to. Does anyone have real numbers for projects that do this vs ones that commit all the vendored code?

If both styles must be supported, perhaps check for the existence of Godeps/_workspace and fall back to godep restore if the directory isn't there.

zackkitzmiller · 2014-10-19T23:39:23Z

I understand the hesitation to encourage that sort of .gitignore, but I've seen it in several projects. Enough to suggest we support the fallback solution. I can code that up a some point tomorrow.

I think that's reasonable.

kr · 2014-10-19T23:48:05Z

Until today, those gitignore projects had to code up their own travis.yml support anyway, so it's not like they're losing much by having that state of affairs continue. The most important thing in good product management is knowing how to say "no". (Ok I think that's all I have to say on the subject. I also agree that the fallback is reasonable, and it's your call of course. 😄)

zackkitzmiller · 2014-10-19T23:55:06Z

@kr Then for now, I'll build in a fallback. ;)

I do agree with the heart of your post, and believe we should encourage people who are vendoring to properly vendor. In the mean time, I think we should lower the friction to automated testing as to as close to zero as possible.

kr · 2014-10-20T00:20:07Z

Cool 👍. Thanks so much for doing the actual work while I sit here lobbing comments from the peanut gallery. ;)

meatballhat · 2014-10-20T00:23:19Z

@kr ❤️

zackkitzmiller · 2014-10-20T00:24:58Z

@kr ❤️

BanzaiMan · 2014-10-20T00:25:48Z

meatballhat · 2014-10-20T00:31:54Z

fwiw, I'd like to suggest (if it's at all possible without appearing to be self-promoting) that we add support for deppy, which is the -copy=false descendant of godep. This is the tool that a small number of us in the community have switched to since godep is dropping support for this way of doing things. I asked @kr a few weeks ago to see if anybody else had picked up the -copy=false fork, so if the answer has changed in the meantime I'll gladly point folks that way instead of letting deppy live on. And with that, I'll drop the subject since this thread is about godep 😸

joshk · 2014-10-20T00:35:04Z

I love you all, so much love in this thread!

zackkitzmiller · 2014-10-20T01:05:06Z

@meatballhat Respectfully, I believe that should be a new issue/PR.

meatballhat · 2014-10-20T01:06:53Z

@zackkitzmiller very much agreed 😃

@kr

Godep integration behavior updates per feedback from @kr on #309

Provide built-in Godep support

cb7cbb0

BanzaiMan assigned meatballhat Oct 18, 2014

joshk reviewed Oct 18, 2014
View reviewed changes

Adjust the gopath bin to use a fully defined path

44631d5

meatballhat reviewed Oct 19, 2014
View reviewed changes

meatballhat added a commit that referenced this pull request Oct 19, 2014

Merge pull request #309 from zackkitzmiller/master

fe56367

Provide built-in Godep support

meatballhat merged commit fe56367 into travis-ci:master Oct 19, 2014

meatballhat pushed a commit that referenced this pull request Oct 19, 2014

Minor touchup post-merge of #309

a0e40f2

meatballhat pushed a commit that referenced this pull request Oct 20, 2014

Godep integration behavior updates per feedback from @kr on #309

3b4701e

BanzaiMan added a commit that referenced this pull request Oct 20, 2014

Merge pull request #312 from travis-ci/db-godep-tweaks

b39fb10

Godep integration behavior updates per feedback from @kr on #309

Provide built-in Godep support #309

Provide built-in Godep support #309

Conversation

zackkitzmiller commented Oct 18, 2014

BanzaiMan commented Oct 18, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

zackkitzmiller commented Oct 19, 2014

meatballhat commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

This comment was marked as spam.

This comment was marked as spam.

meatballhat commented Oct 19, 2014

meatballhat commented Oct 19, 2014

meatballhat commented Oct 19, 2014

meatballhat commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

meatballhat commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

meatballhat commented Oct 19, 2014

kr commented Oct 19, 2014

meatballhat commented Oct 19, 2014

kr commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

kr commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

kr commented Oct 19, 2014

zackkitzmiller commented Oct 19, 2014

kr commented Oct 20, 2014

meatballhat commented Oct 20, 2014

zackkitzmiller commented Oct 20, 2014

BanzaiMan commented Oct 20, 2014

meatballhat commented Oct 20, 2014

joshk commented Oct 20, 2014

zackkitzmiller commented Oct 20, 2014

meatballhat commented Oct 20, 2014