-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module is now v10 compatible only #34
Comments
I made the changes to module.json in an attempt to be compatible with version 10. Is there a way to make a module compatible with both versions 9 and 10? |
You can include both v9 and v10 fields. Like id and name, system/dependencies and the relationships field, minCoreVersion/compatibleCoreaversion and compatibility object field, etc.. |
Is |
Based on that commit, I would assume so. I haven't reviewed the |
Thanks, @kakaroto. I think I have this corrected in the latest release. |
Since aa4372f, you've changed the module.json to use
id
field instead ofname
which makes it v10 compatible, but also means it's unusable in v9.The module's minimum compatibility should be bumped from v0.7.2 to v10 for the 0.10.2+ releases of the module.
Also make sure to update the minimum in the Foundry admin interface (https://foundryvtt.com/packages/grouproll) otherwise any user on v9 trying to install it will have a module that fails to even appear in the module list.
Thanks.
The text was updated successfully, but these errors were encountered: