Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module is now v10 compatible only #34

Closed
kakaroto opened this issue Nov 28, 2022 · 5 comments
Closed

Module is now v10 compatible only #34

kakaroto opened this issue Nov 28, 2022 · 5 comments

Comments

@kakaroto
Copy link

Since aa4372f, you've changed the module.json to use id field instead of name which makes it v10 compatible, but also means it's unusable in v9.
The module's minimum compatibility should be bumped from v0.7.2 to v10 for the 0.10.2+ releases of the module.
Also make sure to update the minimum in the Foundry admin interface (https://foundryvtt.com/packages/grouproll) otherwise any user on v9 trying to install it will have a module that fails to even appear in the module list.
Thanks.

@trdischat
Copy link
Owner

I made the changes to module.json in an attempt to be compatible with version 10. Is there a way to make a module compatible with both versions 9 and 10?

@kakaroto
Copy link
Author

You can include both v9 and v10 fields. Like id and name, system/dependencies and the relationships field, minCoreVersion/compatibleCoreaversion and compatibility object field, etc..

@trdischat
Copy link
Owner

Is name the only thing missing right now?

@kakaroto
Copy link
Author

Based on that commit, I would assume so. I haven't reviewed the module.json or tested it, the issue was just reported to us and I passed it along to you.

@trdischat
Copy link
Owner

Thanks, @kakaroto. I think I have this corrected in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants