move project compilation to server #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice improvements. gogo |
Merged
danielnorberg
force-pushed
the
dano/move-archiving-to-server
branch
from
3a2fbe9
to
78e4c40
Compare
added 2 commits
January 16, 2017 13:25
danielnorberg
changed the title
frsyuki
approved these changes
Jan 16, 2017
| @@ -86,14 +86,11 @@ private void archive(Injector injector) | |||
| ConfigFactory cf = injector.getInstance(ConfigFactory.class); | |||
| ConfigLoaderManager loader = injector.getInstance(ConfigLoaderManager.class); | |||
|
|
|||
| // read parameters | |||
| Config overrideParams = loadParams(cf, loader, loadSystemProperties(), paramsFile, params); | |||
There was a problem hiding this comment.
Two fields (params and paramsFile ) should be removed now?
| Map<String, String> params = new HashMap<>(); | ||
|
|
||
| @Parameter(names = {"-P", "--params-file"}) | ||
| String paramsFile = null; |
There was a problem hiding this comment.
please also update usage() method
| @@ -60,7 +60,7 @@ public void listFiles(PathConsumer consumer) | |||
| } | |||
|
|
|||
| // reused by ProjectArchiveLoader.load | |||
| static void listFiles(Path projectPath, PathConsumer consumer) | |||
| public static void listFiles(Path projectPath, PathConsumer consumer) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the project archive metadata compilation to the server makes it easier for the console to implement workflow editing.