This repository has been archived by the owner on May 23, 2020. It is now read-only.
Switch to using Void instead of Object for event-less subscriptions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| /** | |||
| * Used for event notifications that have no extra data. | |||
| */ | |||
| public static final Object UNIT = new Object(); | |||
| public static final Void UNIT = null; | |||
There was a problem hiding this comment.
I don't think this is necessary - just use null.
There was a problem hiding this comment.
Thanks for the review, fixing it now.
dlew
added a commit
that referenced
this pull request
Oct 28, 2015
Switch to using Void instead of Object for event-less subscriptions
|
Thanks! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9