Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: barlist color improvement on dark mode #723

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

severinlandolt
Copy link
Member

Description

This PR solves the color issue of the barlist with dark mode.

Closes #612
Closes #192

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Oct 1, 2023
@severinlandolt severinlandolt changed the title opacity and color dark mode feat: barlist color improvement on dark mode Oct 1, 2023
@severinlandolt severinlandolt merged commit 7e52af7 into beta Oct 1, 2023
5 of 7 checks passed
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

🎉 This PR is included in version 3.9.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the fix/barlistcolors branch October 8, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
1 participant