fix: <Dialog /> role prop for headlessui version 1.7.18 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
severinlandolt
changed the base branch from
main
to
chore/updatetailwindpackagegs
severinlandolt
added
the
PR: In Review
severinlandolt
merged commit 8dd3a73
into
tremorlabs:chore/updatetailwindpackagegs
5 checks passed
severinlandolt
added a commit
that referenced
this pull request
Jan 9, 2024
* update tailwind packages * fix: <Dialog /> role prop for headlessui version 1.7.18 (#900) * basic dialog component * export dialog * separate root element * dialogpanel componenet * export dialogpanel component * Refactor DialogPanel styles * Refactor dialog display class name * Fix export Dialog to DialogPanel * Update Dialog and DialogPanel styles * overlayClassName * transition added * refactot style * Dialog panel default text color set * dialog story added * Panel ring added * unit testing dialog component * overlay bg updated * dialog border removed * export Dialog component from layout elements * refactor imports * Update import for Dialog components * Story fixes * add: styling * Add role prop to Dialog component. * lint --------- Co-authored-by: severinlandolt <sev.landolt@gmail.com> Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com> Co-authored-by: Severin Landolt <41927988+severinlandolt@users.noreply.github.com> --------- Co-authored-by: Touha Zohair <39002455+iamtouha@users.noreply.github.com> Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new prop
roleforDialogcomponentRelated issue(s)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has this been tested?
Screenshots (if appropriate):
The PR fulfils these requirements:
mainbranch