Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <Dialog /> role prop for headlessui version 1.7.18 #900

Merged
merged 26 commits into from
Jan 9, 2024
Merged

fix: <Dialog /> role prop for headlessui version 1.7.18 #900

Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
69b3711
basic dialog component
iamtouha Dec 31, 2023
720ce66
export dialog
iamtouha Dec 31, 2023
1d4fed7
separate root element
iamtouha Dec 31, 2023
8b3e5f4
dialogpanel componenet
iamtouha Dec 31, 2023
f1343c0
export dialogpanel component
iamtouha Dec 31, 2023
6dd063c
Refactor DialogPanel styles
iamtouha Dec 31, 2023
b1ab987
Refactor dialog display class name
iamtouha Dec 31, 2023
6357685
Fix export Dialog to DialogPanel
iamtouha Dec 31, 2023
1027297
Update Dialog and DialogPanel styles
iamtouha Dec 31, 2023
d73a8d9
overlayClassName
iamtouha Dec 31, 2023
99c7fad
transition added
iamtouha Jan 1, 2024
33f59ff
refactot style
iamtouha Jan 1, 2024
4b9d084
Dialog panel default text color set
iamtouha Jan 1, 2024
0b9b12c
dialog story added
iamtouha Jan 1, 2024
ed5f7a4
Panel ring added
iamtouha Jan 1, 2024
b4185ff
unit testing dialog component
iamtouha Jan 1, 2024
8fe1215
overlay bg updated
iamtouha Jan 1, 2024
0237a5c
dialog border removed
iamtouha Jan 1, 2024
59ad3c8
export Dialog component from layout elements
iamtouha Jan 1, 2024
d411fc3
refactor imports
iamtouha Jan 1, 2024
058d99d
Update import for Dialog components
iamtouha Jan 1, 2024
2c1a4fc
Story fixes
severinlandolt Jan 5, 2024
90ee364
add: styling
christopherkindl Jan 5, 2024
a96d50d
Add role prop to Dialog component.
iamtouha Jan 9, 2024
431686b
Merge branch 'chore/updatetailwindpackagegs' into feat/dialog-component
severinlandolt Jan 9, 2024
5f7afbf
lint
severinlandolt Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/layout-elements/Dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ type XOR<T, U> = T | U extends object ? (Without<T, U> & U) | (Without<U, T> & T
export type DialogProps = React.HTMLAttributes<HTMLDivElement> & {
open: boolean;
onClose: (val: boolean) => void;
role?: "dialog" | "alertdialog";
} & XOR<{ unmount?: boolean }, { static?: boolean }>;

const Dialog = React.forwardRef<HTMLDivElement, DialogProps>((props, ref) => {
const { children, className, ...other } = props;

return (
<Transition as={React.Fragment} appear show={props.open}>
<HeadlessuiDialog
Expand Down
Loading