Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_bookmarks_gs() old bookmark disabling no longer works with ghostscript v10.3 #59

Closed
trevorld opened this issue Mar 28, 2024 · 1 comment · Fixed by #60
Closed

set_bookmarks_gs() old bookmark disabling no longer works with ghostscript v10.3 #59

trevorld opened this issue Mar 28, 2024 · 1 comment · Fixed by #60
Assignees
@trevorld
Labels
bug Something isn't working

Comments

@trevorld
Copy link
Owner

trevorld commented Mar 28, 2024 •
edited

(10.03.0) Almost all the "internal" PostScript procedures defined during the interpreter startup are now "executeonly", further reducing the attack surface of the interpreter.

The nature of these procedures means there should be no impact for legitimate usage, but it is possible it will impact uses which abuse the previous accessibility (even for legitimate reasons). Such cases may now require "DELAYBIND", See DELAYBIND

  • Not entirely sure how to update postscript/ghostscript code to handle these breaking changes if still possible to do so
  • Old bookmarks seem to still be disabled by set_bookmarks_pdftk()
  • Bookmarks are still disabled with ghostscript v9.55
@trevorld trevorld added the bug Something isn't working label Mar 28, 2024
@trevorld trevorld self-assigned this Mar 28, 2024
trevorld added a commit that referenced this issue Mar 28, 2024
@trevorld
fix: Skip certain tests if ghostscript version > 9.55
35999c7 
* ghostscript v10.3 breaks code to disable old bookmarks
* Now skip tests that verify old bookmarks disabled if detects
  ghostscript version is strictly greater than 9.55

see #59
@trevorld
Copy link
Owner Author

  • If you have installed newer/older version of ghostscript in temporary directory can tell {xmpdf} to use it by setting Sys.setenv(R_GSCMD="/path/to/gs")

trevorld added a commit that referenced this issue Mar 29, 2024
@trevorld
fix(set_bookmarks_gs()): Use '-dNO_PDFMARK_OUTLINES'
14cf1f6 
* We can again disable old bookmarks when setting new bookmarks
  in `set_bookmarks_gs()` for the newest versions of `ghostscript`.
  The new approach means we could remove some GPLv3 code and have relicensed the package under the MIT license.
* Instead of using W. Trevor King's postscript files to disable old
  bookmarks we use the (previously undocumented) `-dNO_PDFMARK_OUTLINES`
  flag of `ghostscript`.

closes #59
@trevorld trevorld mentioned this issue Mar 29, 2024
Merged
trevorld added a commit that referenced this issue Mar 29, 2024
@trevorld
fix(set_bookmarks_gs()): Use '-dNO_PDFMARK_OUTLINES'
1a516d6 
* We can again disable old bookmarks when setting new bookmarks
  in `set_bookmarks_gs()` for the newest versions of `ghostscript`.
  The new approach means we could remove some GPLv3 code and have relicensed the package under the MIT license.
* Instead of using W. Trevor King's postscript files to disable old
  bookmarks we use the (previously undocumented) `-dNO_PDFMARK_OUTLINES`
  flag of `ghostscript`.

closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorld trevorld

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(set_bookmarks_gs()): Use '-dNO_PDFMARK_OUTLINES' trevorld/r-xmpdf
1 participant
@trevorld