fix(set_bookmarks_gs()): Use '-dNO_PDFMARK_OUTLINES' #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We can again disable old bookmarks when setting new bookmarks in `set_bookmarks_gs()` for the newest versions of `ghostscript`. The new approach means we could remove some GPLv3 code and have relicensed the package under the MIT license. * Instead of using W. Trevor King's postscript files to disable old bookmarks we use the (previously undocumented) `-dNO_PDFMARK_OUTLINES` flag of `ghostscript`. closes #59
* Can't submit package to CRAN with non-working links and exiv2.org currently doesn't work so instead replace with a link to Github repo. * See Exiv2/exiv2#2875 for more info on exiv2.org is currently down. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_bookmarks_gs()for the newest versions ofghostscript. The new approach means we could remove some GPLv3 code and have relicensed the package under the MIT license.-dNO_PDFMARK_OUTLINESflag ofghostscript.closes #59