Skip to content

Commit

Permalink
Dev - Remove pointer flag from divider meta - not used
Browse files Browse the repository at this point in the history
  • Loading branch information
trevorsandy committed Dec 3, 2018
1 parent d153440 commit d2aae3d
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 25 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ LEGO® is a trademark of the LEGO Group of companies which does not sponsor, aut
[univention-icon]: https://raw.githubusercontent.com/trevorsandy/lpub3d/master/builds/utilities/icons/univention.png
[windows-icon]: https://raw.githubusercontent.com/trevorsandy/lpub3d/master/builds/utilities/icons/windows.png

[windows-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1071_20181203.exe
[macos-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1071_20181203-macos.dmg
[appimage-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1071_20181203-x86_64.AppImage
[windows-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1072_20181203.exe
[macos-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1072_20181203-macos.dmg
[appimage-url]: https://github.com/trevorsandy/lpub3d/releases/download/v2.3.4/LPub3D-2.3.4.1.1072_20181203-x86_64.AppImage

[arch-url]: https://download.opensuse.org/repositories/home:/trevorsandy/Arch_Extra/
[centos-url]: https://download.opensuse.org/repositories/home:/trevorsandy/CentOS_7/
Expand Down
2 changes: 1 addition & 1 deletion builds/linux/obs/alldeps/PKGBUILD
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Maintainer: Trevor SANDY <trevor[dot]sandy[at]gmail[dot]com>
# Last Update October 02, 2018
pkgname=lpub3d
pkgver=2.3.4.1071
pkgver=2.3.4.1072
pkgrel=1
pkgdesc="An LDraw Building Instruction Editor"
url="https://github.com/trevorsandy/lpub3d.git"
Expand Down
6 changes: 3 additions & 3 deletions builds/linux/obs/alldeps/debian/changelog
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
lpub3d (2.3.4.1071) debian; urgency=medium
lpub3d (2.3.4.1072) debian; urgency=medium

* LPub3D version 2.3.4.1.1071_20181203 for Linux
* LPub3D version 2.3.4.1.1072_20181203 for Linux

-- Trevor SANDY <trevor.sandy@gmail.com> Mon, 03 Dec 2018 07:01:37 +0100
-- Trevor SANDY <trevor.sandy@gmail.com> Mon, 03 Dec 2018 07:03:52 +0100
2 changes: 1 addition & 1 deletion builds/linux/obs/alldeps/debian/lpub3d.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Format: 1.0
Source: lpub3d
Binary: lpub3d
Architecture: any
Version: 2.3.4.1071
Version: 2.3.4.1072
Maintainer: Trevor SANDY <trevor.sandy@gmail.com>
Homepage: https://trevorsandy.github.io/lpub3d/
Standards-Version: 3.9.7
Expand Down
4 changes: 2 additions & 2 deletions builds/linux/obs/alldeps/lpub3d.spec
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ BuildRequires: fdupes
Summary: An LDraw Building Instruction Editor
Name: lpub3d
Icon: lpub3d.xpm
Version: 2.3.4.1071
Version: 2.3.4.1072
Release: <B_CNT>%{?dist}
URL: https://trevorsandy.github.io/lpub3d
Vendor: Trevor SANDY
Expand Down Expand Up @@ -711,5 +711,5 @@ update-mime-database /usr/share/mime >/dev/null || true
update-desktop-database || true
%endif

* Mon Dec 03 2018 - trevor.dot.sandy.at.gmail.dot.com 2.3.4.1071
* Mon Dec 03 2018 - trevor.dot.sandy.at.gmail.dot.com 2.3.4.1072
- LPub3D Linux package (rpm) release
Binary file modified builds/utilities/ci/secure/.secrets.tar.enc
Binary file not shown.
2 changes: 1 addition & 1 deletion builds/utilities/version.info
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2 3 4 1 1071 5a0aefa
2 3 4 1 1072 d153440
2 changes: 1 addition & 1 deletion mainApp/docs/README.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
LPub3D 2.3.4.1.1071 (03 12 2018 07:01:37)
LPub3D 2.3.4.1.1072 (03 12 2018 07:03:52)

Features, enhancements, fixes and changes
------------
Expand Down
2 changes: 1 addition & 1 deletion mainApp/docs/RELEASE_NOTES.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<table class="tg">
<tr>
<th class="tg-0pky">
<h4><a id="LPub3D_0"></a>LPub3D 2.3.4.1.1071 (03 12 2018 07:01:37)</h4>
<h4><a id="LPub3D_0"></a>LPub3D 2.3.4.1.1072 (03 12 2018 07:03:52)</h4>
<hr>
<p>
LPub3D version 2.3.3<br>
Expand Down
4 changes: 2 additions & 2 deletions mainApp/meta.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3421,7 +3421,7 @@ CalloutMeta::CalloutMeta() : BranchMeta()
stepNum.color.setValue("black");
// stepNum.font - default
stepNum.placement.setValue(LeftTopOutside,PartsListType);
sep.setValueInches("Black",DEFAULT_THICKNESS,DEFAULT_MARGINS, false);
sep.setValueInches("Black",DEFAULT_THICKNESS,DEFAULT_MARGINS);
BorderData borderData;
borderData.type = BorderData::BdrSquare;
borderData.line = BorderData::BdrLnSolid;
Expand Down Expand Up @@ -3518,7 +3518,7 @@ MultiStepMeta::MultiStepMeta() : BranchMeta()
stepNum.color.setValue("black");
// stepNum.font - default
placement.setValue(CenterCenter,PageType);
sep.setValue("black",DEFAULT_THICKNESS,DEFAULT_MARGINS,false);
sep.setValue("black",DEFAULT_THICKNESS,DEFAULT_MARGINS);
// subModelFont - default
subModelFontColor.setValue("black");
// freeform
Expand Down
8 changes: 2 additions & 6 deletions mainApp/meta.h
Original file line number Diff line number Diff line change
Expand Up @@ -1634,8 +1634,7 @@ class SepMeta : public LeafMeta
void setValue(QString color,
float thickness,
float margin0,
float margin1,
bool haspointer)
float margin1)
{
if (resolutionType() == DPCM) {
thickness = centimeters2inches(thickness);
Expand All @@ -1646,7 +1645,6 @@ class SepMeta : public LeafMeta
_value[pushed].thickness = thickness;
_value[pushed].margin[0] = margin0;
_value[pushed].margin[1] = margin1;
_value[pushed].haspointer= haspointer;
}
void setValue(SepData goods)
{
Expand All @@ -1668,14 +1666,12 @@ class SepMeta : public LeafMeta
void setValueInches(QString color,
float thickness,
float margin0,
float margin1,
bool haspointer)
float margin1)
{
_value[pushed].color = color;
_value[pushed].thickness = thickness;
_value[pushed].margin[0] = margin0;
_value[pushed].margin[1] = margin1;
_value[pushed].haspointer= haspointer;
}
void setValueInches(SepData &sepData)
{
Expand Down
2 changes: 0 additions & 2 deletions mainApp/metatypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -462,13 +462,11 @@ class SepData
float thickness; // in units
QString color;
float margin[2]; // in units
bool haspointer;
SepData()
{
thickness = 0.125;
margin[0] = 0;
margin[1] = 0;
haspointer = false;
}
};

Expand Down
2 changes: 1 addition & 1 deletion mainApp/org.trevorsandy.lpub3d.appdata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<binary>lpub3d23</binary>
​</provides>
<releases>
<release version="2.3.4.1071" date="2018-12-03">
<release version="2.3.4.1072" date="2018-12-03">
<description>
<p>LPub3D Linux AppImage package</p>
</description>
Expand Down
3 changes: 2 additions & 1 deletion mainApp/ranges.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,8 @@ void Steps::addGraphicsItems(

DividerItem *divider = new DividerItem(step,&meta,oX,oY);
divider->setParentItem(parent);
// add the divider pointers to the graphics scene

// add divider pointers (if any) to the graphics scene
for (int i = 0; i < range->dividerPointerList.size(); i++) {
Pointer *pointer = range->dividerPointerList[i];
divider->addGraphicsPointerItem(pointer,range->view);
Expand Down

0 comments on commit d2aae3d

Please sign in to comment.