Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse top-model INCLUDE file at model file load #631

Closed
trevorsandy opened this issue Dec 1, 2022 · 1 comment
Closed

Parse top-model INCLUDE file at model file load #631

trevorsandy opened this issue Dec 1, 2022 · 1 comment
Assignees
Milestone

Comments

@trevorsandy
Copy link
Owner

Subject

Change the current behaviour to parse the top-model INCLUDE file during file load. Settings applied during file load affect the model parsing for page display so it is necessary to pre-set them before the normal model file parse during page display.
With this change, the following settings should be applied if they appear in the top-level INCLUDE file:

  • BUILD_MOD_ENABLED - set whether build modifications are enabled or disabled.
  • START_PAGE_NUMBER - set the start page number used when a build instruction document is split into multiple books.
  • START_STEP_NUMBER - set the start step number used when a build instruction document is split into multiple books.
  • FINAL_MODEL_ENABLED - set whether a final, unmodified, model is displayed when fade previous steps or highlight current step is enabled.
  • LOAD_UNOFFICIAL_PARTS_IN_EDITOR - set whether to load inlined custom unofficial parts into the command editor.

Environment

Version of LPub3D - 2.4.6
Operating system - All

Expected behaviour

Settings needed before the first display page should always be set.

Actual behaviour

Settings needed before the first display page are not set if they are in an INCLUDE file

Solution

Enable expected behaviour.

Cheers,

@trevorsandy trevorsandy added this to the 2.4.6 milestone Dec 1, 2022
@trevorsandy trevorsandy self-assigned this Dec 1, 2022
@trevorsandy
Copy link
Owner Author

Implemented.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant