Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pow(), exp() functions #16

Closed
ibell opened this issue Jun 4, 2016 · 10 comments
Closed

Adding pow(), exp() functions #16

ibell opened this issue Jun 4, 2016 · 10 comments
Milestone

Comments

@ibell
Copy link
Contributor

ibell commented Jun 4, 2016

I'm interested in adding pow and exponential functions to the set of functions. Could you please add them? They are very useful in my fitting routines.

Also, it would be nice if you could describe how you add functions to the library of functions so we could extend it with any function we want.

@trevorstephens
Copy link
Owner

Currently you cannot add your own functions without hacking the source code. I'll look into adding this to the next release though. Thanks for the feedback! 👍

@ibell
Copy link
Contributor Author

ibell commented Jun 5, 2016

Yes, not being able to add my own functions makes me quite frustrated. Would be great if you could make that part more flexible.

@trevorstephens
Copy link
Owner

Noted. I'll probably have to change the API a bit for this to work.

Maybe something like function_set = ['transformer', 'comparison'] as default (rather than having those as first-class init parameters) with the option to add your own user-defined functions in that list.

What do you think @ibell ?

@ibell
Copy link
Contributor Author

ibell commented Jun 5, 2016

Yes, and it would be great if you could have a custom object with a well-defined API in the function_set. Something like a term provider class.

Also, I find the term transformer to not be very descriptive, and you might want to think about a better term if you are changing the API anyway :)

@trevorstephens
Copy link
Owner

transformer is inherited from scikit-learn terminology. It's not going anywhere 😉

@trevorstephens
Copy link
Owner

Fixed by #18

@trevorstephens trevorstephens added this to the 0.2.0 milestone Mar 26, 2017
@smheidrich
Copy link

It's great that user-defined functions now work, but is there any reason why exp isn't part of the predefined functions available out of the box? Seems fairly "standard" to me.

@trevorstephens
Copy link
Owner

Probably because it would be more likely to get into overflow/closure issues than other functions. You can make it yourself if you need it.

@smheidrich
Copy link

Oh ok, thanks for the clarification!

@slavust
Copy link

slavust commented Feb 12, 2022

Or maybe because it then will try to interpolate with polynomial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants