feat: cardano preview testnet #7262
Conversation
vladimirvolek
requested review from
alex-jerechinsky,
marekrjpolak,
tomasklim,
matejkriz,
mroz22,
szymonlesisz and
sime
as code owners
There was a problem hiding this comment.
If I remember correctly packages/connect-common/files/coins.json should be autogenerated from connect-common. So this PR should be accompanied by a corresponding update of submodules
There is some read on this, hope it is up to date
https://github.com/trezor/trezor-suite/blob/develop/docs/packages/connect/supported-coins.md#the-pipeline
|
|
@mroz22 please? |
|
waiting for trezor/trezor-firmware#2716 and submodule update |
|
@mroz22 done |
| @@ -2253,25 +2294,6 @@ | |||
| }, | |||
| "url": "https://www.rinkeby.io" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
looks like we did not update trezor-common with goerli.
could you please, @karliatto have a look? also we were about to get rid of tGOR etc. and replace it with tETH instead. can we do it now, or are we still waiting for blockbooks?
There was a problem hiding this comment.
Can we coordinate this for the March release? It's the next release of FW.
There was a problem hiding this comment.
But anyway after some investigations it looks to me that removing of tGOR has already started in trezor-common and that might be a reason why this is removed from here now by the automatic script. On the other side it looks like the version of submodules/trezor-common used in this PR is a bit outdated.
So tGOR for goerli was part of trezor-common as you can see here trezor/trezor-common@be35125#diff-478bd47ba2f3d059686166afd3b3630d9d2231e2550454d3e5f1eb64f7f788d0 but it is not anymore.
This is the commit that did the changes trezor/trezor-common@a551917#diff-52ccdfbdbb8d7df04c3575c60ece020902c2a4e2f171ce27d826f526ca688c76R39391
But it tGOR is still there in https://github.com/trezor/trezor-common/blob/master/defs/coins_details.json
It looks there are some changes happening in trezor-common, maybe @mmilata can give us more details. And maybe we need to update the update-coins.sh script to new version.
There was a problem hiding this comment.
But it tGOR is still there in https://github.com/trezor/trezor-common/blob/master/defs/coins_details.json
don't look at that file .)
I was under the impression that we decided to keep tGOR and friends (bc it makes it easier to see on Trezor on which testnet you are), no?
current master: https://github.com/trezor/trezor-common/blob/master/defs/duplicity_overrides.json#L18-L19
There was a problem hiding this comment.
Intention is to sync with upstream and avoid special handling.
|
just please run |
|
done |
fix: update coins.json fix: typo fix: allow new testnet in desktop fix: bl link fix: message fix: cardano ttl chore: update trezor-common (b6503f5) chore: update coins.js fix: lint fix: eth testnet fix: tests
vladimirvolek
force-pushed
the
cardano-preview-testnet
branch
from
1f534ea
to
bc43be8
Compare
Adding new
Cardano Preview Testnetnetwork.Legacy testnet will be terminated.