Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e tests work on arm #3616

Closed
goodhoko opened this issue Apr 9, 2021 · 9 comments
Closed

Make e2e tests work on arm #3616

goodhoko opened this issue Apr 9, 2021 · 9 comments
Assignees
Labels
code Code improvements e2e End-to-end tests builded in CI

Comments

@goodhoko
Copy link
Contributor

goodhoko commented Apr 9, 2021

Currently the e2e setup doesn't work out of the box on arm machines (eg. M1 macs). Fix this to make it easy for anyone with arm machine to run e2e tests locally.

This will require several steps some of which need to be done in other repositories. (trezor-user-env, trezord-go, ...). This issue serves as a place to track all these steps leading to seamless e2e tests on M1 macs.

Assigning myself to work on this gradually over time.

@goodhoko goodhoko added Low priority e2e End-to-end tests builded in CI labels Apr 9, 2021
@goodhoko goodhoko self-assigned this Apr 9, 2021
@goodhoko
Copy link
Contributor Author

goodhoko commented Apr 9, 2021

The tests really heavily on the trezor-user-env docker image which must be adapted for arm in the first place. (running the x86 version fails due to NixOS/nix#4485 or rather docker/for-mac#5204).

That, in turn, will require arm64 binaries of the emulator and the bridge and arm64 version of the nix image. For that last there's already an issue.

A good guide on maiking multi-arch docker images seems to be this one.

@tsusanka
Copy link
Contributor

tsusanka commented Apr 9, 2021

That's a bummer :(. I know @prusnak is using Nix natively without Docker so trezor-user-env might work natively on M1. But we would have to alter the e2e tests then not to use trezor-user-env in docker but directly. There is some work needed and since it is just a hypothesis and I am not sure it is worth it :(.

goodhoko added a commit that referenced this issue Apr 9, 2021
1.4 release doesn't provide builds for arm64. Bump to the latest version
(1.12) which does.
goodhoko added a commit that referenced this issue Apr 9, 2021
1.4 release doesn't provide builds for arm64. Bump to the latest version
(1.12) which does.
tsusanka pushed a commit that referenced this issue Apr 13, 2021
1.4 release doesn't provide builds for arm64. Bump to the latest version
(1.12) which does.
@goodhoko
Copy link
Contributor Author

goodhoko commented Jul 8, 2021

This will have to wait for someone else.

@goodhoko goodhoko removed their assignment Jul 8, 2021
@matejzak matejzak added LOW and removed Low priority labels Sep 3, 2021
@hynek-jina hynek-jina added the code Code improvements label Dec 10, 2021
@hynek-jina
Copy link
Contributor

@vdovhanych is this still valid?

@vdovhanych
Copy link
Member

@hynek-jina This is still being worked on but should be resolved for the most part. So i would leave it until we're finished in trezor-user-env

@vdovhanych vdovhanych self-assigned this Dec 14, 2021
@komret
Copy link
Contributor

komret commented May 23, 2022

@ondracja Are you able to run the Cypress tests on an M1? If so, could you please update https://github.com/trezor/trezor-suite/blob/develop/docs/tests/e2e-suite-web.md or write down the difference from the current instructions in this thread? We could then close this issue.

@andrcj
Copy link
Contributor

andrcj commented May 24, 2022

@komret Yes, I'm able to run cypress directly (I use docker only for trezor-user-env). I'll update the README for E2E tests in a near future and then close this issue.

@komret komret mentioned this issue May 24, 2022
23 tasks
@hynek-jina hynek-jina removed the LOW label Jun 8, 2022
@andrcj
Copy link
Contributor

andrcj commented Jun 15, 2022

Since the README update is now merged, I'm closing this issue.

@andrcj andrcj closed this as completed Jun 15, 2022
@bosomt
Copy link
Contributor

bosomt commented Jun 16, 2022

QA OK :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements e2e End-to-end tests builded in CI
Projects
Archived in project
Development

No branches or pull requests

8 participants