-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@trezor/connect stellar plugin #5358
Comments
The latest trezor-connect version is 8.2.8, I'm not sure what you mean by @trezor/connect version 9. There is a bug in the latest version that prevents
It's great to create a separate package, I added some unit tests in trezor/connect#1091, maybe we should add integration tests too |
v9 is the integration https://github.com/trezor/connect into the trezor-suite repository, which includes efforts to convert the codebase to TypeScript. You are right that it is not released yet. |
🎉 #5450 has been merged, I will be integrating the new code in Stellar Laboratory this week to see if it works as expected. |
I will let you know once this is released to npm |
@overcat please try we are going to focus on updating docs now, so please let us know if there is something uncleare. |
Hi @mroz22, I got an error when I tried to upgrade, could you please take a look? code change: https://github.com/overcat/laboratory/pull/1/files error info: Cannot find module '@trezor/transport/lib/types/messages' from 'node_modules/@trezor/connect/lib/constants/index.js' |
Will be tested by 3rd party.. No requirements on QA. |
Hi @overcat |
Hi @mroz22, got another error while running the test, which I think is caused by @trezor/connect. log: https://github.com/overcat/laboratory/runs/6986247890?check_suite_focus=true
|
ouch, you are right, sorry, I will need to improve my checks to prevent this. Working on that. |
Sooo,
|
I think this error is not caused by upgrading trezor libraries. |
✅ I ran some tests and all test cases pass. Version:
Device: Model T and Model One with the latest firmware Laboratory url: https://laboratory-mihyld7ic-overcat.vercel.app/#txsigner?network=test test cases
|
@mroz22 Can we close the issue? |
I think we can close it for now. If there are still problems, @overcat can always reopen. So far thaks for collaboration! |
trezor-connect is being migrated from old repository to this place.
Asses the state of stellar 3rd party implementation. Are there some? Is @trezor/connect version 9 good enough for them to work?
We probably should create @trezor/connect-plugin-stellar see in the old codebase here but there are multiple versions of stellar-sdk. It would be great if we were sure that the newly created plugin works with the latest version and has some tests also.
cc: @overcat
related
#4876 #4890
The text was updated successfully, but these errors were encountered: