trezor-connect migration #5212
Merged
trezor-connect migration #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlesisz
force-pushed
the
connect-core
branch
3 times, most recently
from
7df2004
to
23e491a
Compare
Nodonisko
reviewed
Apr 6, 2022
Nodonisko
reviewed
Apr 6, 2022
szymonlesisz
force-pushed
the
connect-core
branch
from
fdb5a40
to
3b34f78
Compare
mroz22
force-pushed
the
connect-core
branch
16 times, most recently
from
5103995
to
f0f7bc7
Compare
mroz22
force-pushed
the
connect-core
branch
7 times, most recently
from
1e0a24f
to
898f2c8
Compare
chore(connect-web): move webextension chore(connect-web): move webusb
mroz22
force-pushed
the
connect-core
branch
2 times, most recently
from
48be27e
to
fc5fbd8
Compare
szymonlesisz
approved these changes
May 11, 2022
| @@ -68,7 +68,7 @@ module.exports = { | |||
| global: { | |||
| statements: 65, | |||
| branches: 58, | |||
| functions: 66, | |||
| functions: 64, | |||
|
|
||
| ## Tests | ||
|
|
||
| For integration testing against trezord and emulator refer to [this document](./tests/README.md). |
| @@ -2,19 +2,23 @@ | |||
|
|
|||
| ## Main differences between suite-web and suite-desktop builds | |||
|
|
|||
| ### trezor-connect API | |||
| ### @trezor/connect API | |||
There was a problem hiding this comment.
fix doc/connect index (text and links)
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3461
affects #4973
Code review
trezor-connectpackage(docs included)@trezor/connect documentation and examples #5349index file similar to connect.trezor.io/8replaced with connect-explorerCI:
Scripts for deployment@trezor/conenct deployment #5350Test
@trezor/connect-examples
agree on folder structure? Incorporate into monorepo structure or not?@trezor/connect documentation and examples #5349electron renderer with asset works (dev, and build)@trezor/connect documentation and examples #5349electron renderer with popup works (dev and build)@trezor/connect documentation and examples #5349electron main process works (dev and build)@trezor/connect documentation and examples #5349webextension - update docs, don't forget about trezor-usb-permissions from @trezor/connect-web/webextension@trezor/connect documentation and examples #5349@trezor/connect-plugins-*
agree on folder structure? should we install plugins dependencies into root dependencies?@trezor/conenct deployment #5350@connect/popup
Builds:
Deployment
Create connect.trezor.io/9 url for testing?@trezor/conenct deployment #5350Release @trezor/connect-web and @trezor/connect v9 npm packages?@trezor/conenct deployment #5350Manage repos
deprecate https://github.com/trezor/connect-explorer repo but mantain https://trezor.github.io/connect-explorer/deprecate old connect-explorer #5352keep and mantain (for some time ?) https://github.com/trezor/connect but update README@trezor/connect documentation and examples #5349Followup:
yarn workspace @trezor/connect-iframe devwill not fully work without runningyarn workspace @trezor/connect-popup buildbeforehead. Should we use some webpack configs merging strategy here?connect-buildpackage. is it worth? should we create an issue?