-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trezor-connect migration #5212
trezor-connect migration #5212
Conversation
7df2004
to
23e491a
Compare
fdb5a40
to
3b34f78
Compare
5103995
to
f0f7bc7
Compare
1e0a24f
to
898f2c8
Compare
chore(connect-web): move webextension chore(connect-web): move webusb
48be27e
to
fc5fbd8
Compare
@@ -68,7 +68,7 @@ module.exports = { | |||
global: { | |||
statements: 65, | |||
branches: 58, | |||
functions: 66, | |||
functions: 64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
|
||
## Tests | ||
|
||
For integration testing against trezord and emulator refer to [this document](./tests/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix link
@@ -2,19 +2,23 @@ | |||
|
|||
## Main differences between suite-web and suite-desktop builds | |||
|
|||
### trezor-connect API | |||
### @trezor/connect API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix doc/connect index (text and links)
QA OK Info:
|
resolves #3461
affects #4973
Code review
trezor-connect
package(docs included)@trezor/connect documentation and examples #5349index file similar to connect.trezor.io/8replaced with connect-explorerCI:
Scripts for deployment@trezor/conenct deployment #5350Test
@trezor/connect-examples
agree on folder structure? Incorporate into monorepo structure or not?@trezor/connect documentation and examples #5349electron renderer with asset works (dev, and build)@trezor/connect documentation and examples #5349electron renderer with popup works (dev and build)@trezor/connect documentation and examples #5349electron main process works (dev and build)@trezor/connect documentation and examples #5349webextension - update docs, don't forget about trezor-usb-permissions from @trezor/connect-web/webextension@trezor/connect documentation and examples #5349@trezor/connect-plugins-*
agree on folder structure? should we install plugins dependencies into root dependencies?@trezor/conenct deployment #5350@connect/popup
Builds:
Deployment
Create connect.trezor.io/9 url for testing?@trezor/conenct deployment #5350Release @trezor/connect-web and @trezor/connect v9 npm packages?@trezor/conenct deployment #5350Manage repos
deprecate https://github.com/trezor/connect-explorer repo but mantain https://trezor.github.io/connect-explorer/deprecate old connect-explorer #5352keep and mantain (for some time ?) https://github.com/trezor/connect but update README@trezor/connect documentation and examples #5349Followup:
yarn workspace @trezor/connect-iframe dev
will not fully work without runningyarn workspace @trezor/connect-popup build
beforehead. Should we use some webpack configs merging strategy here?connect-build
package. is it worth? should we create an issue?