Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite): remove cross-fetch, we dont need it as we use node18 everywhere #12252

Closed
wants to merge 1 commit into from

Conversation

peter-sanderson
Copy link
Contributor

Description

Related Issue

Resolve #10146

Screenshots:

@mroz22
Copy link
Contributor

mroz22 commented May 3, 2024

doesn't it break bridge communication for long lasting /call calls?

@martykan
Copy link
Member

martykan commented May 3, 2024

Yeah it had to be reverted last time (after a bunch of painful troubleshooting)
#11820

@peter-sanderson
Copy link
Contributor Author

Ouch, lets wait for Node 19 then.

@peter-sanderson peter-sanderson deleted the cross-fetch-dependency branch May 3, 2024 11:00
@marekrjpolak
Copy link
Contributor

Ouch, lets wait for Node 19 then.

And what will 19 change? What we need is unlimited timeout by default.

@peter-sanderson
Copy link
Contributor Author

@marekrjpolak I was following on Komars message on Slack that we may try again when we upgrade node.

We can try removing cross-fetch again when we upgrade node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cross-fetch lib as we use Node18 everywhere
4 participants