Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(transport, trezor-user-env-link): remove cross-fetch" #11820

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

komret
Copy link
Contributor

@komret komret commented Mar 28, 2024

Description

Apparently there are differences in the native fetch and cross-fetch as we came over a problem with timeouts.

Details: https://satoshilabs.slack.com/archives/C02V2PSDNA2/p1711539811017599

Reverting the removal of cross-fetch.

@komret komret added the dependencies Pull requests that update a dependency file label Mar 28, 2024
@komret komret requested a review from mroz22 as a code owner March 28, 2024 14:50
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@emotion/hash@0.9.1 environment 0 10.2 kB emotion-release-bot
npm/@emotion/sheet@1.2.2 environment 0 30.8 kB emotion-release-bot
npm/@emotion/unitless@0.8.1 environment 0 7.05 kB emotion-release-bot
npm/@emotion/utils@1.2.1 environment 0 18.3 kB emotion-release-bot
npm/@emotion/weak-memoize@0.3.1 environment 0 6.08 kB emotion-release-bot
npm/@popperjs/core@2.11.8 None 0 1.46 MB fezvrasta
npm/@types/react-dom@18.2.19 None 0 33.2 kB types
npm/clsx@2.1.0 None 0 8.46 kB lukeed
npm/dotenv@16.4.5 environment, filesystem 0 79.1 kB motdotla
npm/find-root@1.1.0 filesystem 0 5.27 kB jsdnxx

🚮 Removed packages: npm/@aashutoshrathi/word-wrap@1.2.6, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/plugin-syntax-jsx@7.24.1, npm/@eslint-community/regexpp@4.10.0, npm/@gar/promisify@1.1.3, npm/@hapi/hoek@9.3.0, npm/@hookform/resolvers@3.3.4, npm/@humanwhocodes/module-importer@1.0.1, npm/@humanwhocodes/object-schema@2.0.2, npm/@jridgewell/trace-mapping@0.3.25, npm/@nodelib/fs.stat@2.0.5, npm/@pkgjs/parseargs@0.11.0, npm/@polka/url@1.0.0-next.21, npm/@radix-ui/number@1.0.1, npm/@radix-ui/primitive@1.0.1, npm/@radix-ui/react-focus-guards@1.0.1, npm/@radix-ui/react-use-escape-keydown@1.0.3, npm/@sideway/formula@3.0.1, npm/@sideway/pinpoint@2.0.0, npm/@sinonjs/commons@3.0.1, npm/@swc/core@1.4.11, npm/@tootallnate/once@2.0.0, npm/@types/estree@1.0.5, npm/@types/json-schema@7.0.15, npm/@types/qs@6.9.7, npm/@types/semver@7.5.8, npm/@types/yargs@17.0.32, npm/acorn@8.11.3, npm/ansi-html-community@0.0.8, npm/ansi-regex@5.0.1, npm/argparse@2.0.1, npm/array-includes@3.1.8, npm/array-union@2.1.0, npm/array.prototype.flatmap@1.3.2, npm/asap@2.0.6, npm/assert-plus@1.0.0, npm/astral-regex@1.0.0, npm/async@3.2.5, npm/asynckit@0.4.0, npm/at-least-node@1.0.0, npm/babel-plugin-jest-hoist@29.6.3, npm/balanced-match@1.0.2, npm/bech32@2.0.0, npm/binary-extensions@2.3.0, npm/bitcoin-ops@1.4.1, npm/bluebird@3.7.2, npm/buffer@6.0.3, npm/bytes@3.1.2, npm/callsites@3.1.0, npm/camelcase@5.3.1, npm/caniuse-lite@1.0.30001600, npm/character-entities-legacy@3.0.0, npm/chardet@0.7.0, npm/chownr@2.0.0, npm/cjs-module-lexer@1.2.3, npm/clean-stack@2.2.0, npm/cli-width@3.0.0, npm/co@4.6.0, npm/color-name@1.1.3, npm/comma-separated-tokens@2.0.3, npm/commander@4.1.1, npm/commondir@1.0.1, npm/connect-history-api-fallback@2.0.0, npm/content-type@1.0.5, npm/convert-source-map@2.0.0, npm/core-util-is@1.0.3, npm/css-what@6.1.0, npm/cssesc@3.0.0, npm/damerau-levenshtein@1.0.8, npm/debug@4.3.4, npm/decode-uri-component@0.2.2, npm/deep-extend@0.6.0, npm/deep-is@0.1.4, npm/deepmerge@4.3.1, npm/define-lazy-prop@2.0.0, npm/delayed-stream@1.0.0, npm/depd@2.0.0, npm/destroy@1.2.0, npm/diff-sequences@29.6.3, npm/domelementtype@2.3.0, npm/domhandler@4.3.1, npm/eastasianwidth@0.2.0, npm/emittery@0.13.1, npm/emoji-regex@9.2.2, npm/encodeurl@1.0.2, npm/entities@4.5.0, npm/env-paths@2.2.1, npm/es-module-lexer@1.4.1, npm/es6-promise@4.2.8, npm/escalade@3.1.1, npm/escape-html@1.0.3, npm/escape-string-regexp@1.0.5, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-visitor-keys@3.4.3, npm/esprima@4.0.1, npm/esutils@2.0.3, npm/eventemitter3@4.0.7, npm/events@3.3.0, npm/extend@3.0.2, npm/fast-json-stable-stringify@2.1.0, npm/fast-levenshtein@2.0.6, npm/fbjs-css-vars@1.0.2, npm/filter-obj@1.1.0, npm/flatted@3.3.1, npm/form-data@3.0.1, npm/fresh@0.5.2, npm/fsevents@2.3.3, npm/function-bind@1.1.2, npm/functions-have-names@1.2.3, npm/gensync@1.0.0-beta.2, npm/get-caller-file@2.0.5, npm/get-package-type@0.1.0, npm/get-stream@4.1.0, npm/globals@11.12.0, npm/graceful-fs@4.2.11, npm/graphemer@1.4.0, npm/has-flag@4.0.0, npm/html-entities@2.3.3, npm/http-cache-semantics@4.1.1, npm/http-proxy-agent@5.0.0, npm/https-proxy-agent@5.0.1, npm/human-signals@2.1.0, npm/iconv-lite@0.4.24, npm/ignore@5.3.1, npm/indent-string@4.0.0, npm/ini@1.3.8, npm/ipaddr.js@1.9.1, npm/is-arrayish@0.2.1, npm/is-buffer@1.1.6, npm/is-callable@1.2.7, npm/is-docker@2.2.1, npm/is-extglob@2.1.1, npm/is-fullwidth-code-point@3.0.0, npm/is-negative-zero@2.0.3, npm/is-path-inside@3.0.3, npm/is-plain-obj@3.0.0, npm/is-promise@2.2.2, npm/is-stream@1.1.0, npm/is-typedarray@1.0.0, npm/is-unicode-supported@0.1.0, npm/isarray@2.0.5, npm/isobject@3.0.1, npm/isstream@0.1.2, npm/jest-docblock@29.7.0, npm/jest-get-type@29.6.3, npm/jest-regex-util@29.6.3, npm/js-tokens@4.0.0, npm/jsesc@2.5.2, npm/json-buffer@3.0.1, npm/json-parse-even-better-errors@2.3.1, npm/json-stable-stringify-without-jsonify@1.0.1, npm/json5@2.2.3, npm/jsonc-parser@3.2.0, npm/kind-of@6.0.3, npm/kleur@3.0.3, npm/language-subtag-registry@0.3.22, npm/leven@3.1.0, npm/lodash.camelcase@4.3.0, npm/lodash.debounce@4.0.8, npm/lodash.merge@4.6.2, npm/lodash@4.17.21, npm/long@4.0.0, npm/lowercase-keys@2.0.0, npm/mdast-util-to-string@3.2.0, npm/mdurl@1.0.1, npm/merge2@1.4.1, npm/methods@1.1.2, npm/mime-db@1.52.0, npm/mime@2.6.0, npm/mimic-fn@2.1.0, npm/mimic-response@1.0.1, npm/minimist@1.2.8, npm/minipass@4.2.8, npm/ms@2.1.2, npm/mute-stream@0.0.8, npm/nanoid@3.3.7, npm/natural-compare@1.4.0, npm/negotiator@0.6.3, npm/neo-async@2.6.2, npm/node-forge@1.3.1, npm/normalize-path@3.0.0, npm/normalize-url@6.1.0, npm/object-assign@4.1.1, npm/object-inspect@1.13.1, npm/os-tmpdir@1.0.2, npm/p-finally@1.0.0, npm/p-try@2.2.0, npm/pako@1.0.11, npm/parseurl@1.3.3, npm/path-exists@4.0.0, npm/path-is-absolute@1.0.1, npm/path-key@3.1.1, npm/path-parse@1.0.7, npm/path-to-regexp@0.1.7, npm/path-type@4.0.0, npm/picomatch@2.3.1, npm/postcss-value-parser@4.2.0, npm/postcss@8.4.38, npm/prelude-ls@1.2.1, npm/pretty-bytes@5.6.0, npm/proxy-from-env@1.1.0, npm/queue-microtask@1.2.3, npm/quick-lru@5.1.1, npm/react@18.2.0, npm/regenerate@1.4.2, npm/regenerator-runtime@0.14.1, npm/resolve-from@5.0.0, npm/reusify@1.0.4, npm/run-async@2.4.1, npm/safer-buffer@2.1.2, npm/sax@1.2.4, npm/setimmediate@1.0.5, npm/shebang-regex@1.0.0, npm/signal-exit@3.0.7, npm/sisteransi@1.0.5, npm/smart-buffer@4.2.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Environment variable access npm/@emotion/hash@0.9.1
New author npm/find-root@1.1.0
Filesystem access npm/find-root@1.1.0
Environment variable access npm/@emotion/unitless@0.8.1
Environment variable access npm/@emotion/utils@1.2.1
Environment variable access npm/@emotion/sheet@1.2.2
Environment variable access npm/@emotion/weak-memoize@0.3.1
Filesystem access npm/dotenv@16.4.5
Environment variable access npm/dotenv@16.4.5
Environment variable access npm/dotenv@16.4.5
Environment variable access npm/ansi-escapes@6.2.1
  • orphan: npm/ansi-escapes@6.2.1

View full report↗︎

Next steps

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@emotion/hash@0.9.1
  • @SocketSecurity ignore npm/find-root@1.1.0
  • @SocketSecurity ignore npm/@emotion/unitless@0.8.1
  • @SocketSecurity ignore npm/@emotion/utils@1.2.1
  • @SocketSecurity ignore npm/@emotion/sheet@1.2.2
  • @SocketSecurity ignore npm/@emotion/weak-memoize@0.3.1
  • @SocketSecurity ignore npm/dotenv@16.4.5
  • @SocketSecurity ignore npm/ansi-escapes@6.2.1

@komret komret enabled auto-merge (rebase) March 28, 2024 14:53
@komret komret merged commit 8d92964 into develop Mar 28, 2024
77 of 82 checks passed
@komret komret deleted the fix/reintroduce-cross-fetch branch March 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants