Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(coinmarket): buy/sell/exchange detail #12506

Closed
wants to merge 7 commits into from

Conversation

adderpositive
Copy link
Contributor

Description

A small refactoring mainly focused on reducing duplicities:

  • The files useCoinmarketBuyDetail.ts, useCoinmarketSellDetail.ts and useCoinmarketExchangeDetail.ts - merged into one file useCoinmarketDetail.ts and moved to the /coinmarket folder.
  • Created useCoinmarketWatchTrade.ts in the /coinmarket folder with the useCoinmarketWatchTrade hook which is integrates three very similar functions - useWatchBuyTrade, useWatchSellTrade and useWatchExchangeTrade.
  • Created watchTrade function in invityAPI.ts, combining watchBuyTrade, watchSellTrade and watchExchangeTrade functions.
  • Used types from the newly created file coinmarketDetail.ts in the /types folder (a focus on merging types to one place).
  • Generally, using folders to separate Coinmarket from other features.

@adderpositive adderpositive added the +Invity Related to Invity project label May 21, 2024
@adderpositive adderpositive self-assigned this May 21, 2024
@adderpositive adderpositive linked an issue May 21, 2024 that may be closed by this pull request
@adderpositive adderpositive deleted the refactor/coinmarket branch May 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+Invity Related to Invity project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(coinmarket): buy/sell/exchange detail
1 participant