Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(send): ETH erc20 estimated gas limit #3418

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix(send): ETH erc20 estimated gas limit #3418

merged 1 commit into from
Feb 17, 2021

Conversation

szymonlesisz
Copy link
Contributor

estimate fee should be called using erc20 address, not recipient address

@szymonlesisz szymonlesisz added the READY FOR REVIEW Developed pull request ready to be reviewed by another developer label Feb 16, 2021
@tsusanka tsusanka merged commit 8fcfeeb into develop Feb 17, 2021
@tsusanka tsusanka deleted the fix/eth-erc20-gaslimit branch February 17, 2021 08:03
@bosomt
Copy link
Contributor

bosomt commented Feb 20, 2021

QA OK

Info:

  • Suite version: web 21.3.0 (a0f6944)
  • Browser: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.3.5 regular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraf keraf keraf approved these changes

@robertbrada robertbrada Awaiting requested review from robertbrada

@slowbackspace slowbackspace Awaiting requested review from slowbackspace

Assignees
No one assigned
Labels
READY FOR REVIEW Developed pull request ready to be reviewed by another developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szymonlesisz @bosomt @keraf @tsusanka