feat(suite): Coin Control #6019

komret · 2022-08-16T13:47:50Z

Enable coin control in Suite.

Description

Coin selection is enable for Bitcoin (including its test and regtest) in send form. There is a new option Coin control:

When coin selection is used (but hidden manually), it looks like this:

When the Coin control button is clicked, but there are no UTXOs, this message is displayed (copy needed):

If there are any UTXOs and the button is clicked, UTXOs selected by the UTXO lib are checked with grey background:

To turn manual coin selection on, click on the switch or any of the checkboxes:

In case the user has dust in their account, it is shown at the end of the list of UTXOs as a separate category (copy needed):

Pagination is used when there is more than 25 UTXOs:

When hovering over a UTXO, buttons to see transaction details and add label are shown:

When not enough funds are selected, there is a message. At this point, we do not know the final fee, so it is excluded (copy needed):

When the selected funds are enough to cover the outputs, but there is not enough for a fee, a different message is shown (copy needed):

UTXOs on change addresses are marked (users won't have them labeled from transaction history):

Related Issue

Resolve #2770

@b-irving, please check the copy in points 3, 6, 9 and 10.

QA: The above points correspond to what to test, please look for any edge cases as well. There is also fiat amount shown for every UTXO when not on a testnet.

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx

dahaca

Great job! 🤓

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx

suite-common/wallet-constants/src/sendForm.ts

dahaca · 2022-09-01T14:24:21Z

packages/suite/src/components/wallet/UtxoSelection.tsx

+                        <>
+                            <Dot />
+                            <ChangeAddress>
+                                <Translation id="TR_CHANGE_ADDRESS" />


Perhaps would make sense to add a tooltip and a guide article? @hynek-jina

@dahaca Where would be the tooltip? I can't imagine it from these few lines..

it may sound like call to action 😄

Yes, i think the tooltip would be nice..

it may sound like call to action

I like to use a dash to emphasize that it's a single term, so "change-address" or "change-output", but I don't think it's widely used.

I would stick to change address or only change

With reference to Bitcoin Design
https://bitcoin.design/guide/glossary/address/#change-address

@b-irving please decide 🙂

let's solve it as a followup

packages/suite/src/components/wallet/UtxoSelection.tsx

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx

packages/suite/src/components/wallet/UtxoSelectionList.tsx

packages/suite/src/hooks/wallet/form/useUtxoSelection.ts

packages/suite/src/hooks/wallet/useSendForm.ts

packages/suite/src/views/wallet/send/components/Options/components/BitcoinOptions/index.tsx

matejkriz

It looks great and the PR is well structured in commits - easy to follow 👍

matejkriz · 2022-09-02T08:16:10Z

packages/suite/src/hooks/wallet/form/useUtxoSelection.ts

+            setValue(
+                'selectedUtxos',
+                !selectedUtxos.length && !isCoinControl
+                    ? [...new Set([...preselectedUtxos, utxo])]


Does this work as expected here with objects? This prevents to add utxo object with the reference already existing in preselectedUtxos array, but doesn't prevent to add the same utxo with different reference - wouldn't it be safer to check it by txid and vout?

@dahaca please check 3719247 [EDIT: I put the wrong commit before.]

Honestly, I am not following what this code does, could you explain?

Are selectedUtxosOld the pre-selected ones?

selectedUtxosOld are the pre-selected ones only if Coin Control is not enabled and user turning the Coin Control on by selecting some UTXO. If Coin Control is already enabled, selectedUtxosOld are those already selected. I know it's a bit confusing, not sure how to name it better. Maybe it would be useful to add a comment?

Yes, a commend would be great. Also what about preselectedUtxos?

I added the comments and made a refactored it a little bit in 206f141. I did not change the variable names because preselectedUtxos is already used.

packages/suite/src/views/wallet/send/components/Options/components/BitcoinOptions/index.tsx

matejkriz · 2022-09-02T08:53:11Z

packages/suite/src/components/wallet/UtxoSelection.tsx

+                        <>
+                            <Dot />
+                            <ChangeAddress>
+                                <Translation id="TR_CHANGE_ADDRESS" />


it may sound like call to action 😄

packages/suite/src/components/suite/Labeling/components/Metadata/definitions.ts

dahaca · 2022-09-02T12:06:04Z

it may sound like call to action 😄

Also figuring that out with Ondra

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx

komret force-pushed the feat/utxo-selection-new branch 5 times, most recently from 3f9fd61 to d5be092 Compare August 18, 2022 11:28

komret force-pushed the feat/utxo-selection-new branch 10 times, most recently from 1826f1a to 1915783 Compare August 30, 2022 18:22

komret added bitcoin Bitcoin related send Send page labels Aug 30, 2022

komret added this to the CoinJoin 🥣 milestone Aug 30, 2022

komret force-pushed the feat/utxo-selection-new branch 4 times, most recently from 4e7b3d4 to 959eff8 Compare August 31, 2022 16:26

dahaca changed the title ~~Feat/utxo selection new~~ feat(suite): Coin Control Aug 31, 2022

dahaca self-assigned this Aug 31, 2022

dahaca marked this pull request as ready for review August 31, 2022 17:37

dahaca requested review from tomasklim, matejkriz and dahaca as code owners August 31, 2022 17:37

Nodonisko reviewed Aug 31, 2022

View reviewed changes

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx Outdated Show resolved Hide resolved

hynek-jina assigned matejkriz Sep 1, 2022

dahaca suggested changes Sep 1, 2022

View reviewed changes

matejkriz reviewed Sep 2, 2022

View reviewed changes

matejkriz unassigned dahaca Sep 2, 2022

matejkriz reviewed Sep 2, 2022

View reviewed changes

packages/suite/src/components/suite/Labeling/components/Metadata/definitions.ts Outdated Show resolved Hide resolved

matejkriz assigned dahaca and unassigned matejkriz Sep 2, 2022

Nodonisko reviewed Sep 5, 2022

View reviewed changes

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx Outdated Show resolved Hide resolved

Nodonisko reviewed Sep 5, 2022

View reviewed changes

...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx Show resolved Hide resolved

Nodonisko approved these changes Sep 6, 2022

View reviewed changes

komret requested a review from alex-jerechinsky as a code owner September 7, 2022 10:12

komret force-pushed the feat/utxo-selection-new branch from 206f141 to 0df2878 Compare September 7, 2022 10:52

szymonlesisz and others added 13 commits September 7, 2022 12:59

feat(suite): Send form utxo selection

194b1fa

feat(components): add coin control icon

5ac6f10

feat(suite): add coin control button

387a75e

feat(suite): style standalone label button

4a4f663

feat(suite): enhance coin control functionality and styles

aaf1fe6

feat(suite): add dust section to coin selection

dc9771f

feat(suite): add pagination to coin selection

1f02f5d

feat(suite): fetch all transactions in coin selection

79105e9

feat(suite): change switch and checkbox behaviour in coin selection

6ae0239

feat(suite): display missing amount to input in coin selection

e56c2a5

feat(suite): make utxos selectable on click, show label button on hover

dac74e6

feat(suite): add fiat amount to UtxoSelection

e81914f

feat(suite): add detail button to UtxoSelection, improve styles

c453cb5

komret force-pushed the feat/utxo-selection-new branch from 0df2878 to c453cb5 Compare September 7, 2022 11:02

dahaca approved these changes Sep 7, 2022

View reviewed changes

komret merged commit 23e369d into develop Sep 7, 2022

komret deleted the feat/utxo-selection-new branch September 7, 2022 11:39

komret mentioned this pull request Sep 7, 2022

Coin control 🎯 #2770

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(suite): Coin Control #6019

feat(suite): Coin Control #6019

komret commented Aug 16, 2022 •

edited

Loading

dahaca left a comment

dahaca Sep 1, 2022

hynek-jina Sep 2, 2022

matejkriz Sep 2, 2022

hynek-jina Sep 2, 2022

andrewkozlik Sep 2, 2022 •

edited

Loading

hynek-jina Sep 2, 2022

hynek-jina Sep 2, 2022

matejkriz Sep 7, 2022

matejkriz left a comment

matejkriz Sep 2, 2022

matejkriz Sep 2, 2022 •

edited

Loading

dahaca Sep 2, 2022

dahaca Sep 2, 2022

matejkriz Sep 5, 2022

dahaca Sep 6, 2022 •

edited

Loading

komret Sep 7, 2022

matejkriz Sep 2, 2022

dahaca commented Sep 2, 2022

feat(suite): Coin Control #6019

feat(suite): Coin Control #6019

Conversation

komret commented Aug 16, 2022 • edited Loading

Description

Related Issue

dahaca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewkozlik Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matejkriz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matejkriz Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dahaca Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dahaca commented Sep 2, 2022

komret commented Aug 16, 2022 •

edited

Loading

andrewkozlik Sep 2, 2022 •

edited

Loading

matejkriz Sep 2, 2022 •

edited

Loading

dahaca Sep 6, 2022 •

edited

Loading