Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coin control 🎯 #2770

Closed
matejzak opened this issue Oct 27, 2020 · 15 comments · Fixed by #6019, #6152 or #6156
Closed

Coin control 🎯 #2770

matejzak opened this issue Oct 27, 2020 · 15 comments · Fixed by #6019, #6152 or #6156
Assignees
@komret
Labels
bitcoin Bitcoin related coinjoin Related to coinjoin feature feature Product related issue visible for end user
Projects
Trezor · Suite · Roadmap 🔥 Backlog 🗂
Milestone
🥣 Coinjoin - MVP

Comments

@matejzak
Copy link

matejzak commented Oct 27, 2020 •
edited by hynek-jina

The aim is to allow users to opt-in for manual coin selection instead of automatic coin selection when making an outgoing transaction.

Automatic coin selection should remain default, users have to be informed, that switching to manual will let them take control of their strategy for transaction optimisation.

Default Send flow in Suite will remain almost untouched, except a button, which will enable Coin control.: 
2 2 1 — Accounts — Send Coin Control

Opened Coin Control: 
2 2 1 — Accounts — Coin Control Opened

Coin control on 
2 2 1 — Accounts — Custom Coin Selection

Closed coin control button detail:

Coin control OFF Coin control ON
Button coincontrol on

Change UI element for send max to toggle:

send max old →  send amx

Edge cases and other notes in Notion
@matejzak matejzak self-assigned this Oct 27, 2020
@matejzak matejzak added this to .. Considering 🔮 in Trezor · Suite · Roadmap 🔥 Oct 27, 2020
@matejzak matejzak added the Suite label Oct 27, 2020
@matejzak matejzak moved this from .. Upcoming 🔮 to May 🌼 in Trezor · Suite · Roadmap 🔥 Feb 4, 2021
@matejzak matejzak moved this from May 13 to .. Upcoming 🔮 in Trezor · Suite · Roadmap 🔥 Mar 8, 2021
@jziggas jziggas mentioned this issue Apr 19, 2021
Closed
@matejzak matejzak moved this from .. Upcoming 🔮 to July 14 in Trezor · Suite · Roadmap 🔥 Apr 20, 2021
@matejzak matejzak moved this from July 14 to August 11 in Trezor · Suite · Roadmap 🔥 May 7, 2021
@matejzak matejzak moved this from August 11 to July 14 in Trezor · Suite · Roadmap 🔥 May 7, 2021
@xanoni

This comment was marked as off-topic.

Sign in to view
@matejzak matejzak moved this from July 14 to August 11 in Trezor · Suite · Roadmap 🔥 Jun 2, 2021
@matejzak matejzak moved this from August 11 to September 8 in Trezor · Suite · Roadmap 🔥 Jun 10, 2021
@xanoni

This comment was marked as off-topic.

Sign in to view
@matejzak matejzak moved this from September 8 to .. Upcoming 🔮 in Trezor · Suite · Roadmap 🔥 Jul 27, 2021
@matejzak matejzak moved this from .. Upcoming 🔮 to November 10 in Trezor · Suite · Roadmap 🔥 Jul 27, 2021
@HeroHann

This comment was marked as off-topic.

Sign in to view
@ste7

This comment was marked as off-topic.

Sign in to view
@matejzak matejzak moved this from November 10 to Upcoming 🚀 in Trezor · Suite · Roadmap 🔥 Sep 1, 2021
@matejzak matejzak added the HIGH label Sep 6, 2021
@alex-jerechinsky alex-jerechinsky moved this from Inbox 📥 to Product in Suite · Backlog 🗂 Oct 4, 2021
@matejzak matejzak removed the Suite label Oct 7, 2021
@alex-jerechinsky alex-jerechinsky added this to 📥 Inbox in Backlog 🗂 via automation Oct 21, 2021
@alex-jerechinsky alex-jerechinsky moved this from 📥 Inbox to 📽 Product in Backlog 🗂 Oct 21, 2021
@alex-jerechinsky alex-jerechinsky removed this from 📽 Product in Suite · Backlog 🗂 Oct 21, 2021
@matejzak matejzak added MEDIUM and removed HIGH labels Nov 5, 2021
@trymeouteh
Copy link

Would like this feature for all UTXO coins supported in Trezor Suite (BTC, BCH, LTC, DASH, DGB, etc) and have this feature enabled by default to prevent any errors of a new installation of sending funds from two or more addresses out.

@hynek-jina hynek-jina added the feature Product related issue visible for end user label Dec 17, 2021
@0xmichalis

This comment was marked as off-topic.

Sign in to view
@prusnak
Copy link
Member

prusnak commented Jan 16, 2022

WIP PR in #4281

@xanoni

This comment was marked as off-topic.

Sign in to view
@kn0wmad

This comment was marked as off-topic.

Sign in to view
@trezor trezor deleted a comment from xanoni Mar 26, 2022
@nmullesch

This comment was marked as off-topic.

Sign in to view
@hynek-jina hynek-jina removed the MEDIUM label Jun 8, 2022
@hynek-jina hynek-jina assigned hynek-jina and unassigned matejzak Jul 19, 2022
@hynek-jina hynek-jina added this to the CoinJoin 🥣 milestone Jul 20, 2022
@hynek-jina hynek-jina added the bitcoin Bitcoin related label Jul 20, 2022
@hynek-jina hynek-jina assigned komret and unassigned hynek-jina Jul 20, 2022
@hynek-jina hynek-jina changed the title CoinControl 🐾 Coin control 🎯 Jul 23, 2022
@komret komret mentioned this issue Aug 16, 2022
Merged
@komret komret mentioned this issue Aug 30, 2022
Merged
@komret komret linked a pull request Aug 30, 2022 that will close this issue
Coin control prerequisite: "send max" switch #6152
Merged
@komret komret mentioned this issue Aug 30, 2022
Merged
@komret komret linked a pull request Aug 30, 2022 that will close this issue
Coin control prerequisite: reused components #6156
Merged
@komret komret reopened this Aug 31, 2022
@prusnak prusnak reopened this Aug 31, 2022
@bosomt
Copy link
Contributor

bosomt commented Sep 1, 2022

We probably should move this issue back from Needs QA to In progress right ?

@hynek-jina
Copy link
Contributor

@bosomt I've moved it back to Needs review where it now belongs..

@komret
Copy link
Contributor

komret commented Sep 7, 2022

QA: The screens here are a little outdated, please check the main PR (#6019) for a more detailed list of changes. More QA comments are included in the PRs.

This was referenced Sep 7, 2022
Merged
Merged
@STew790
Copy link
Contributor

STew790 commented Sep 15, 2022

QA OK
All PRs approved by QA.

@hynek-jina hynek-jina added the coinjoin Related to coinjoin feature label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@komret komret

Labels
bitcoin Bitcoin related coinjoin Related to coinjoin feature feature Product related issue visible for end user
Projects
Issues Suite
Archived in project
Backlog 🗂
📽 Product
Trezor · Suite · Roadmap 🔥
Spec & design 🧠
Milestone
🥣 Coinjoin - MVP