Coin control fixes #6247
Merged
Coin control fixes #6247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
added
send
komret
requested review from
tomasklim,
matejkriz and
dahaca
as code owners
matejkriz
reviewed
Sep 12, 2022
komret
force-pushed
the
fix/coin-control-button
branch
from
715b42a
to
8ed9197
Compare
|
I removed the other commit, bitcoin-like networks have been tested now, let's support them from the beginning. It would be nice to cherry-pick the icon fix into the release, though. |
komret
force-pushed
the
fix/coin-control-button
branch
from
37d5463
to
8ed9197
Compare
|
I found one more bug related to computation and fixed it in 8ed9197. |
|
Since you are making the changes, could you change the margin between the header and controls here to 20px? 🙏
|
dahaca
suggested changes
Sep 12, 2022
...rc/views/wallet/send/components/Options/components/BitcoinOptions/components/CoinControl.tsx
Outdated
Show resolved
Hide resolved
dahaca
previously approved these changes
Sep 13, 2022
komret
force-pushed
the
fix/coin-control-button
branch
from
56302c0
to
7bfea84
Compare
matejkriz
approved these changes
Sep 13, 2022
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coin control bugfixes
Description
visibilitytodisplayto prevent it from breaking the layout when too longRelated Issue
#2770
Screenshots (if appropriate):
SVG icon before and after:
Rounding before and after:
QA: This should fix incorrect computations in the "Missing to your input" message. It happened with some specific numbers in the previous version, e.g. 0.5988788. Please check the rounding is correct.