Chore/metadata refactoring 2 #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
chore/metadata-refactoring-2
branch
2 times, most recently
from
7542ad0
to
7eecf1e
Compare
mroz22
force-pushed
the
chore/metadata-refactoring-2
branch
from
7eecf1e
to
3507789
Compare
mroz22
commented
Aug 28, 2023
matejkriz
reviewed
Aug 28, 2023
packages/suite/src/actions/suite/constants/metadataConstants.ts
Outdated
Show resolved
Hide resolved
matejkriz
reviewed
Aug 28, 2023
matejkriz
reviewed
Aug 28, 2023
Comment on lines
648
to
650
| const nextMetadata = data | ||
| ? (JSON.parse(JSON.stringify(data)) as AccountLabels) | ||
| : JSON.parse(JSON.stringify(METADATA.DEFAULT_ACCOUNT_METADATA)); |
There was a problem hiding this comment.
Note to myself - check if as AccountLabels can be avoided here easily
There was a problem hiding this comment.
probably yes. I am checking it now
There was a problem hiding this comment.
uh, not so easily :( it would require a typequard
There was a problem hiding this comment.
maybe it's a good idea to add the sanitization (and typeguard) as a followup 🤔
|
@mroz22 prettier check failed, other than that LGTM |
mroz22
force-pushed
the
chore/metadata-refactoring-2
branch
from
1e37370
to
93002e2
Compare
matejkriz
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
here I continue (#9218) adding changes to make review of #9130 feasible
Commits
1c188b0 - it is not needed to sync all the keys every time. once keys are there, they never change. when migrations come to play we call these syncs relatively more often.
c351707 - moving constatns to constants. they are going to be reused in metadataActions
3049739 - add actions refactor
3507789 - unreleated, when runnign this test locally, it wouldn't clear defaults and fail on subsequent runs.