-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata encryption v2 (confirm-less labeling) #9130
base: develop
Are you sure you want to change the base?
Conversation
ab1b36a
to
25c4479
Compare
ca52c1b
to
97759e2
Compare
ed90995
to
e016e27
Compare
e016e27
to
e50496c
Compare
e50496c
to
9b6c8c0
Compare
4379e53
to
1b962bf
Compare
5ac7d1d
to
925d554
Compare
migratedFrom?: string; | ||
/** | ||
* we might create some dummy data to make it hard to guess number of labels by file size | ||
*/ | ||
dummy?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also bump version
field saved in file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might make sense to keep track of this dac3416
5a54597
to
b36b9f6
Compare
b36b9f6
to
f3ef29b
Compare
9bed51a
to
19858e8
Compare
e4441ba
to
53ec390
Compare
check how it behaves if user have also some legacy files in apps/trezor/apps/trezor, see https://github.com/trezor/trezor-suite/blob/metadata-migrations-meows/packages/suite/src/services/suite/metadata/DropboxProvider.ts/#L129 |
53ec390
to
66eeaf8
Compare
This PR implements "confirm-less labeling" feature. Previously, you needed to confirm "Enable labeling" dialogue on device screen. This is not needed anymore, or, more specifically, after this is merged the aforementioned dialogue will appear only once (in optimistic scenario).
Changes:
Migration procedure
entitiesToMigrate
: don't have new file && have old fileentititiesToCreateDummies
: don't have new file && don't have old fileNotes
To test
Related
Followups: