fix: disable metadata enable for empty/bootloader devices #9288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejkriz
reviewed
Aug 28, 2023
| @@ -40,7 +40,7 @@ export const Labeling = () => { | |||
| // - Labeling enabled without any device connected | |||
| // - Labeling enabled with the device connected inside Settings | |||
| // The initialization of Labeling then start when user select a Wallet. | |||
| const isDisabled = !!device && !metadata.enabled && isLocked(); | |||
| const isDisabled = (!!device && !metadata.enabled && isLocked()) || device?.mode !== 'normal'; | |||
There was a problem hiding this comment.
What about this?
Suggested change
| const isDisabled = (!!device && !metadata.enabled && isLocked()) || device?.mode !== 'normal'; | |
| const isDisabled = !!device && !metadata.enabled && (isLocked() || device?.mode !== 'normal'); |
So with empty/bootloader device I can still disable the labeling, but enabling is not allowed?
matejkriz
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing #9130 I accidentally discovered a little bug. When you get into application settings with device which is not initialized, it is still possible to click "enable labeling". This feature however requires call to device which is not possible for such device. As a quick fix I suggest disabling this button as this action would fail anyway.