fix(coinmarket): Fix address label not showing in dropdown #9539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
requested changes
Sep 25, 2023
Comment on lines
92
to
94
| const accountMetadata = useSelector( | ||
| state => account && selectLabelingDataForAccount(state, account.key), | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const accountMetadata = useSelector( | |
| state => account && selectLabelingDataForAccount(state, account.key), | |
| ); | |
| const accountMetadata = useSelector( | |
| state => selectLabelingDataForAccount(state, account?.key), | |
| ); |
If this component can be rendered without account
I believe it would be better to modify selectLabelingDataForAccount so that it accepts undefined as a key and handle it inside the method instead of this conditional selector
There was a problem hiding this comment.
Another option is to simply pass account?.key || ''
There was a problem hiding this comment.
if you are about to make changes to selector, please consider changes in selectors in this branch #9130 so that I don't have to solve too many conflicts :D
There was a problem hiding this comment.
fixed by account?.key || '' as also used in other places
tomasklim
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix address label not showing in dropdown.
Description
When user sets a label for any bitcoin or bitcoin-like receiving address, the label is then not showing in the exchange flow.
Related Issue
Resolve #9532
Screenshots: