Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integrate with amplabs.ai API Read/GET endpoints #605

Open
pghege opened this issue May 26, 2022 · 0 comments
Open

[Feature Request] Integrate with amplabs.ai API Read/GET endpoints #605

pghege opened this issue May 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@pghege
Copy link

pghege commented May 26, 2022

AmpLabs provides access to Battery Data via an Open API defined here There can be a neat/streamlined mechanism to make data available in BEEP from the AmpLabs API.

To support read behavior I anticipate the following:

  • Create new file beep.structure.amplabs.py
  • Define new BEEPDataPath subclass called AmpLabsDataPath in beep.structure.amplabs.py
    • Leverage BatteryArchiveDataPath as an example though can integrate directly to API here
  • Define fetch_cell_from_api() within beep.structure.amplabs.py that can fetch individual cell data from AmpLabs API and load into BEEPDataPath.
    • Leverage fetch single cell endpoint on AmpLabs API
  • Define fetch_dataset_from_api() within beep.structure.cli that can fetch datasets from AmpLabs API and load into a list of BEEPDataPath, this should live in https://github.com/TRI-AMDD/beep/blob/master/beep/structure/cli.py
    • This will leverage fetch bulk cell endpoint on AmpLabs API
@pghege pghege added the enhancement New feature or request label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant