Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test suite fails when test output and reference output are both hdf5 #48

Closed
d-cogswell opened this issue Apr 8, 2021 · 2 comments · Fixed by #49
Closed

Regression test suite fails when test output and reference output are both hdf5 #48

d-cogswell opened this issue Apr 8, 2021 · 2 comments · Fixed by #49
Assignees
@d-cogswell
Labels
bug Something isn't working

Comments

@d-cogswell
Copy link
Collaborator

When both varDataNew and varDataRef are h5py Datasets, the subtraction operator in compare_tests.py throws a type error. I think the solution is to use numpy array slicing to convert the Datasets to numpy arrays.
@d-cogswell d-cogswell added the bug Something isn't working label Apr 8, 2021
@d-cogswell d-cogswell self-assigned this Apr 8, 2021
@lightningclaw001
Copy link
Collaborator

@d-cogswell do you still get the bug in the new version of the branch? i think i added something earlier today that helps

@d-cogswell d-cogswell mentioned this issue Apr 8, 2021
Merged
@d-cogswell d-cogswell linked a pull request Apr 8, 2021 that will close this issue
Fix for Issue #48 #49
Merged
d-cogswell added a commit that referenced this issue Apr 13, 2021
@d-cogswell
Merge pull request #49 from TRI-AMDD/issue-48
7ea2446 
Fix for Issue #48
@d-cogswell
Copy link
Collaborator Author

Resolved by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-cogswell d-cogswell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Issue #48 TRI-AMDD/mpet
2 participants
@lightningclaw001 @d-cogswell