Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tune toasts #7

Closed
otakup0pe opened this issue Jun 19, 2020 · 4 comments
Closed

tune toasts #7

otakup0pe opened this issue Jun 19, 2020 · 4 comments
Labels
enhancement New feature or request ux the interface should not harm the participant

Comments

@otakup0pe
Copy link
Contributor

starting in the black rock desert you ain't gonna find any oak. so we need to pull (at least) that toast. @ziz can you think of any others we should pull?
@otakup0pe otakup0pe added enhancement New feature or request ux the interface should not harm the participant labels Jun 19, 2020
@ziz
Copy link
Contributor

ziz commented Jun 19, 2020

probably just kick all the tutorial/recipe book toasts to the curb? tutorializing is going to be in the form of the questbook and JEI is the recipe list. (I'm fond of the advancement toasts myself.)

@otakup0pe
Copy link
Contributor Author

advancement toasts being the ones which are displayed for non-quest advancements? yeah i want to keep those, and figure we'll tie lots of them to quest items.

@otakup0pe
Copy link
Contributor Author

I think the toasts are fine now, thoughts @ziz ?

@ziz
Copy link
Contributor

ziz commented Jun 28, 2020

yeah, looks like 23002a5 resolved this

@ziz ziz closed this as completed Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ux the interface should not harm the participant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ziz @otakup0pe